Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Add crucible #2497

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

RyanPereiraS
Copy link

@RyanPereiraS RyanPereiraS commented Oct 9, 2023

Forge & Spigot Egg

Description

Crucible is a Thermos fork containing various patches for bug fixes and performance improvements.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@QuintenQVD0
Copy link
Collaborator

You forgot all readme's

and the egg readme is not on how to import it but things like needed ports, links to the github

special things users should know

and we mentioned multiple times that we will not add mc eggs anymore
afbeelding

also this egg needs a lot more work as hard setting the version is a no go, you should have a look at our scripts

@QuintenQVD0 QuintenQVD0 marked this pull request as draft October 9, 2023 16:55
@QuintenQVD0
Copy link
Collaborator

QuintenQVD0 commented Oct 9, 2023

I converted it to draft as it as is not done and to be honnest I do not that this is special enough to be merged as a minecraft egg

and mincraft 1.7.10 is long EOL

@RyanPereiraS
Copy link
Author

Oh, I will correct the readme.

I created this egg because there are several servers in 1.7.10, And there are still hosts that provide Mohist as a framework option for 1.7.10, even when the Mohist team itself asked Crucible members to merge it.

I don't know what criteria the team uses to evaluate the eggs, but I believe that Crucible is a good addition to the eggs, as it is the only option for 1.7.10 that still receives updates and bug fixes

@RyanPereiraS
Copy link
Author

I will check the existing scripts, the complex configuration is due to an incompatibility with OR in Ptero's regex, and I didn't want to have to use 2 version fields.

Adding Crucible description to egg readme
^ Improving installation script.

+ Add Crucible description to Egg.

+ Added support for "staging" versions

+ Adding support for versions lower than v5.4 and higher than v5.0. (lib download)

^ Minor edits to variables.
@RyanPereiraS
Copy link
Author

Hello Again, I made several modifications to the script following the bases you have in the repo.
I also changed other things that I saw that could be improved, such as the Readme and the Egg Description.

As I said, Crucible is a project that has several bug-fixes, both from Thermos itself and from Plugins & Mods, and is currently the only platform that still has corrections and improvements updates.

@RyanPereiraS
Copy link
Author

If you have any questions about the project and its importance, I am available to help in any way possible, I can even call one of the developers who followed the egg creation process to help me with this.

@RyanPereiraS RyanPereiraS marked this pull request as ready for review October 12, 2023 16:35
@QuintenQVD0
Copy link
Collaborator

you still mised some README.md files :)

@RyanPereiraS
Copy link
Author

Well, after a lot of commits I believe I changed all the Readme correctly

Copy link
Author

@RyanPereiraS RyanPereiraS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it seems correct

Copy link
Author

@RyanPereiraS RyanPereiraS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, changing all the Redmi I found using the path that referenced Minecraft, could you check if it is OK?

Copy link
Author

@RyanPereiraS RyanPereiraS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything working

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants