add a 'paste' command to write a local file to the terminal #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This definition can be useful in other parts of the code too. Signed-off-by: Roland Hieber <rhi@pengutronix.de>
Make clear that this is meant as batch processing for CLI commands instead of executing e.g. an external shell script. Signed-off-by: Roland Hieber <rhi@pengutronix.de>
This command can be useful as replacement for the clipboard, e.g. when working
remotely over SSH, and when file transfer to the target is not available
otherwise.
Usage example (glados is my host machine, RPi3 is the target, non-printable key
presses in angle brackets):
rohieb@glados:~ $ cat apparmor-profile
#include <tunables/global>
profile /usr/bin/rauc {
#include <abstractions/base>
capability sys_rawio,
/usr/bin/rauc mr,
/usr/bin/barebox-state cx,
/usr/sbin/unsquashfs cx,
/usr/bin/busybox.nosuid cx,
/run/rauc/bundle/hook.sh Ux,
/tmp/** rw,
/mnt/updatebundle.rauc rk,
/etc/rauc/* r,
/proc/cmdline r,
/proc/*/fd/ r,
/proc/*/mountinfo r,
/run/rauc/** rw,
/dev/mmcblk* rw,
/sys/devices/**/mmcblk*/mmcblk*boot*/force_ro rw,
/etc/ssl/openssl.cnf r,
}
rohieb@glados:~ $ microcom -s 115200 /dev/ttyUSB0
root@RPi3:~ cat /usr/share/apparmor/usr.bin.rauc
cat: can't open '/usr/share/apparmor/usr.bin.rauc': No such file or directory
root@RPi3:~ cat > /usr/share/apparmor/usr.bin.rauc
<Ctrl-\>
Enter command. Try 'help' for a list of builtin commands
-> paste apparmor-profile
----------------------
#include <tunables/global>
profile /usr/bin/rauc flags=(attach_disconnected) {
#include <abstractions/base>
capability sys_rawio,
/usr/bin/rauc mr,
/usr/bin/barebox-state cx,
/usr/sbin/unsquashfs cx,
/usr/bin/busybox.nosuid cx,
/run/rauc/bundle/hook.sh Ux,
/tmp/** rw,
/mnt/updatebundle.rauc rk,
/etc/rauc/* r,
/proc/cmdline r,
/proc/*/fd/ r,
/proc/*/mountinfo r,
/run/rauc/** rw,
/dev/mmcblk* rw,
/sys/devices/**/mmcblk*/mmcblk*boot*/force_ro rw,
/etc/ssl/openssl.cnf r,
}
<Ctrl-D>
root@RPi3:~ ls -l /usr/share/apparmor/usr.bin.rauc
-rw-r--r-- 1 root root 521 Sep 1 00:12 /usr/share/apparmor/usr.bin.rauc
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
rohieb
changed the title
paste command to write a local file to the terminal
|
Does anyone want to review this? :-) |
a3f
requested changes
Oct 14, 2021
| @@ -145,6 +145,38 @@ static int cmd_break(int argc, char *argv[]) | |||
| return MICROCOM_CMD_START; | |||
| } | |||
|
|
|||
| static int cmd_paste(int argc, char *argv[]) | |||
| { | |||
| int fd = -1; | |||
| static int cmd_paste(int argc, char *argv[]) | ||
| { | ||
| int fd = -1; | ||
| int i = 1; |
| return -ret; | ||
| } | ||
|
|
||
| while (i > 0) { |
There was a problem hiding this comment.
move check after initializing i with proper value.
| if (i < 0) { | ||
| ret = errno; | ||
| fprintf(stderr, "%s\n", strerror(ret)); | ||
| return -ret; |
| return -ret; | ||
| } | ||
|
|
||
| ios->write(ios, buf, i); |
There was a problem hiding this comment.
You call write with i=0 here on last iteration. Is that intended? Otherwise move check between read and write. also consider early exit here on failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command can be useful as replacement for the clipboard, e.g. when working remotely over SSH, and when file transfer to the target is not available otherwise.
Usage example (
gladosis my host machine,RPi3is the target, non-printable key presses in angle brackets):