crypto: create new crate, scratch work #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
force-pushed
the
crypto-stub
branch
from
ea81fb8
to
e133018
Compare
Adds asset identifiers and value commitment generator computation. Adds a basic test of value commitments with different bases. This commit changes the workspace to use a Penumbra fork of some of the arkworks crates. The current change is in the Display impl for Fp* instances. The fork's `ours` branch is based off of `v0.3.0`, in order to not pick up any unreleased breaking changes.
hdevalence
force-pushed
the
crypto-stub
branch
from
e133018
to
4c32464
Compare
redshiftzero
reviewed
Oct 4, 2021
| @@ -0,0 +1,37 @@ | |||
| // XXX move into poseidon377 crate? | |||
There was a problem hiding this comment.
maybe as a method on this struct (which we can rename, but the struct has one public method implemented following roughly the C2SP variable-length hash so we could add a fixed-length hash_1) or just as a standalone function
There was a problem hiding this comment.
One thing I'm wondering is whether it would make sense to split the upstream code in ark-sponge into two levels, one that just does the permutation, and then another that tracks the sponge state on top of that.
There was a problem hiding this comment.
crypto/src/value.rs
Outdated
|
|
||
| let v = Fr::from(self.amount); | ||
|
|
||
| // XXX would be more convenient for decaf377 not to |
There was a problem hiding this comment.
fair, can always add back later 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds asset identifiers and value commitment generator computation.
Also changes the workspace to use a Penumbra fork of some of the
arkworks crates. The current change is in the Display impl for Fp* instances.
The fork's
oursbranch is based off ofv0.3.0, in order to not pick up anyunreleased breaking changes.