Skip to content

Commit

Permalink
Remove deny(warnings) from crate config (arkworks-rs#28)
Browse files Browse the repository at this point in the history
While it's useful to disallow warnings in CI, adding `deny(warnings)` to the
crate is actively harmful, as it breaks the code whenever the compiler adds new
warnings.  This has a negative effect on downstream users.  For instance, it's
not currently possible to view the documentation for the current version of the
code, since `cargo doc` fails on a warning about Markdown formatting.

More elaboration can be found here:

https://www.reddit.com/r/rust/comments/f5xpib/psa_denywarnings_is_actively_harmful/
  • Loading branch information
hdevalence authored Oct 2, 2021
1 parent c9f7d24 commit 51d6fc9
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
trivial_casts,
trivial_numeric_casts,
unused,
variant_size_differences,
warnings
variant_size_differences
)]
#![forbid(unsafe_code)]

Expand Down

0 comments on commit 51d6fc9

Please sign in to comment.