Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB-883 tokudb broken after 'create database log002015' #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BohuTANG
Copy link
Contributor

[summary]
In is_a_logfile_any_version, the uninitialized variable is terrible when we complied with -O3 flag, if we have a directory named 'log02015', 'n' is undefined value after sscanf

Copyright (c) 2015, BohuTANG
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

  1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
  2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

@george-lorch
Copy link
Contributor

Great catch, preliminary review looks good. I'll look at it again tomorrow and see if a test case can be created for it.

@BohuTANG
Copy link
Contributor Author

test case is here:
https://github.com/percona/tokudb-engine/pull/294/files

It's better to use github issues instead of atlassian.
Everything is tracked via github 💃

@george-lorch
Copy link
Contributor

I would prefer a PerconaFT type ctest rather than an mtr case, I can try to create one for you.

We don't use github issues as they are too 'simple' and don't match our workflow. We will be moving bug tracking over to launchpad within the percona-server project as the various repos get merged.

@BohuTANG BohuTANG force-pushed the bugfix_db_broken_database_log02015_DB883 branch from 8766dce to c84b391 Compare September 20, 2015 11:07
@BohuTANG BohuTANG closed this Sep 20, 2015
@BohuTANG BohuTANG reopened this Sep 20, 2015
@BohuTANG
Copy link
Contributor Author

add FT type test

@BohuTANG BohuTANG force-pushed the bugfix_db_broken_database_log02015_DB883 branch from c84b391 to d36155c Compare September 20, 2015 11:13
[summary]
In is_a_logfile_any_version, the uninitialized variable is terrible when we complied with -O3 flag, if we have a directory named 'log02015', 'n' is undefined value after sscanf

Copyright (c) 2015, BohuTANG
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
@BohuTANG BohuTANG force-pushed the bugfix_db_broken_database_log02015_DB883 branch from d36155c to d6ac910 Compare September 20, 2015 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants