Add local-lib for easy caching
#28
Conversation
Although the environment variable part is going to be a bit harder
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "install-with-cpanm", | |||
| "version": "1.0.0", | |||
| "description": "[](https://github.com/perl-actions/install-with-cpanm/actions)", | |||
| "version": "1.0", | |||
There was a problem hiding this comment.
You might want to change version here to the last one, 1.5?
| `-v` is for verbosity | ||
|
|
||
|
|
||
| ## License |
There was a problem hiding this comment.
I added this license for clarity, since I was forking. You might want either to delete it, or to expand collaborator names from nicks.
There was a problem hiding this comment.
indeed we might prefer a more generic Perl'ish license
There was a problem hiding this comment.
Then you will need to change the short license name in package.json, assuming that artistic-2.0 is compatible with it. I guess ISC (the one here, which I just transcribed, keeping it in package.json) is the license in the boilerplate originally used, but it's pretty permissive, so I guess it's not a problem to change it. IIRC, the artistic will need to add a LICENSE file too here.
|
There's a lot of commit history here. 😅 |
This was the usual 'it worked in my computer', but apparently eslint upgraded from yesterday to now, which caused this stuff...
There was a problem hiding this comment.
This looks good to me.
Note squashing all these changes as one would have been fine too.
I can see multiple ideas like s/var/let/g or other that could have their own commit
but in the end it s seems pretty good change.
The main questionable part is the license.
thanks for submitting it
| `-v` is for verbosity | ||
|
|
||
|
|
||
| ## License |
There was a problem hiding this comment.
indeed we might prefer a more generic Perl'ish license
| `-v` is for verbosity | ||
|
|
||
|
|
||
| ## License |
There was a problem hiding this comment.
Then you will need to change the short license name in package.json, assuming that artistic-2.0 is compatible with it. I guess ISC (the one here, which I just transcribed, keeping it in package.json) is the license in the boilerplate originally used, but it's pretty permissive, so I guess it's not a problem to change it. IIRC, the artistic will need to add a LICENSE file too here.
|
@JJ Would you mind squashing and force push the change? |
|
Not really, but you know that you can do that with a single click when merging, right? Click on the triangle to display the merging options, and then select "Squash and merge". You can then edit or delete individual commit messages... |
Mainly would close #2. Also general ♻️ for JS code, and add a linter for future checks.