perf(cu): optimize between cron messages function #774 #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrain99
changed the title
jfrain99
force-pushed
the
jfrain99/optimize-between-cron-function
branch
from
98a9752
to
0d9138a
Compare
jfrain99
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #774
Attempt at optimization of cron messages between algorithm. While the algorithm remains O(C * T), where C is the number of cron messages and T is the number of seconds in the range, in the worst case, changes were made so that smaller optimizations can be realized. Namely, checks are now only performed on certain seconds, not each second.
It is worth noting that O(CT) is the best possible time complexity for this algorithm, as all crons will need to be checked at each interval.