Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aos): save input history after exiting a session #329 #336

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

Jeremiahstockdale
Copy link
Contributor

Currently the input history for a session is saved, where a user can us the up arrow key to cycle through previous inputs.

This PR is to save the 100 most recent history items in order to give access to them after the session is closed and restarted.

@twilson63
Copy link
Collaborator

It should read/write the file in the Users HOME directory not the current directory they are in

Copy link
Collaborator

@twilson63 twilson63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The history files should be managed in the users home directory, from what I can tell you are writing them into the cwd

Copy link
Collaborator

@twilson63 twilson63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@Jeremiahstockdale Jeremiahstockdale merged commit abd3c9f into main Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants