Fix Staking/Unstaking Bugs & Security Improvements #347
Conversation
`.prepend` finalize handler and add `currentHeight = nil` finalization rule
Set UnstakingDelay = 670 as a Global Removing this as an option on messages removes the risk of it being manually overriden(or set to 1). Without this, anyone can continuously stake, vote, unstake, and then send to another address and repeat the process. this leaves voting as insecure and is a loophole in the security model. This change along with the previous update to .prepend the finalization Handler are included.
if unstakeInfo.release_at == nil or currentHeight >= unstakeInfo.release_at then
blueprints/staking.lua
Outdated
| local height = tonumber(msg['Block-Height']) | ||
| assert(Balances[msg.From] and bint(Balances[msg.From]) >= quantity, "Insufficient balance to stake") | ||
| Balances[msg.From] = utils.subtract(Balances[msg.From], msg.Tags.Quantity) | ||
| Stakers[msg.From] = Stakers[msg.From] or { amount = "0" } | ||
| Stakers[msg.From].amount = utils.add(Stakers[msg.From].amount, msg.Tags.Quantity) | ||
| Stakers[msg.From].unstake_at = height + delay | ||
| Stakers[msg.From].unstake_at = height + UnstakeDelay | ||
| print("Successfully Staked " .. msg.Tags.Quantity) | ||
| msg.reply({ Data = "Successfully Staked " .. msg.Tags.Quantity}) |
There was a problem hiding this comment.
Looks like we need to check if .reply is supported here
reverted to the original stakers.balance function
|
Are we sure we want to force all users of this staking blueprint to use the staking delay setting of 670? It seems it is very explicit this was implemented allowing a staker to choose their staking delay, I understand your concern about being zero, but we should check with others |
The main reason is to prevent someone from continuously staking/voting/unstaking and repeating the process. Without hard-coding some kind of safety on the staking lua this can be tampered with. Ideally it should be |
.prependfinalize handler and addcurrentHeight = nilfinalization ruleThe handler was not seeing block heights at the bottom of the stack and could not execute.
Set UnstakeDelay = 670 as a Global
Removing UnstakeDelay as an option on messages removes the risk of it being manually overriden(or set to 1).
Without this, anyone can continuously stake, vote, unstake, and then send to another address and repeat the process. this leaves voting as insecure and is a loophole in the security model.