Merge pull request #115 from perplexhub/feature/throw_conversion_exce…

…ption

Throw conversion exception #107

rsql-common/src/main/java/io/github/perplexhub/rsql/ConversionException.java

@@ -0,0 +1,7 @@
+package io.github.perplexhub.rsql;
+
+public class ConversionException extends RSQLException {
+    public ConversionException(String message, Throwable cause) {
+        super(message, cause);
+    }
+}

rsql-common/src/main/java/io/github/perplexhub/rsql/RSQLVisitorBase.java

@@ -85,12 +85,10 @@ protected Object convert(String source, Class targetType) {
 			}
 
 			return object;
-		} catch (DateTimeParseException | IllegalArgumentException e) {
-			log.debug("Parsing [{}] with [{}] causing [{}], skip", source, targetType.getName(), e.getMessage());
 		} catch (Exception e) {
 			log.error("Parsing [{}] with [{}] causing [{}], add your parser via RSQLSupport.addConverter(Type.class, Type::valueOf)", source, targetType.getName(), e.getMessage(), e);
+			throw new ConversionException(String.format("Failed to convert %s to %s type", source, targetType.getName()), e);
 		}
-		return null;
 	}
 
 	protected void accessControl(Class type, String name) {

rsql-common/src/test/java/io/github/perplexhub/rsql/RSQLVisitorBaseTest.java

@@ -0,0 +1,36 @@
+package io.github.perplexhub.rsql;
+
+import io.github.perplexhub.rsql.model.User;
+import org.aspectj.lang.annotation.Before;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.springframework.core.convert.support.ConfigurableConversionService;
+
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+@ExtendWith(MockitoExtension.class)
+class RSQLVisitorBaseTest {
+
+    @Spy
+    RSQLVisitorBase unit;
+    @Mock
+    ConfigurableConversionService defaultConversionService;
+
+    @BeforeEach
+    void init() {
+        RSQLVisitorBase.setDefaultConversionService(defaultConversionService);
+    }
+
+    @Test
+    void testConversionException() {
+        assertThatExceptionOfType(ConversionException.class)
+                .isThrownBy(() -> unit.convert("abc", Integer.class))
+                .satisfies(e -> assertEquals("Failed to convert abc to java.lang.Integer type", e.getMessage()));
+
+    }
+}