Feat:[공통] Pagination 마지막 페이지 체크 로직 보완 #85 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-rybczinski
commented
Feb 11, 2024
Comment on lines
+5
to
+15
| class BreedsPaginationResponse extends PaginationResponse<Breed> { | ||
| BreedsPaginationResponse({ | ||
| required this.page, | ||
| required this.size, | ||
| required this.items, | ||
| required super.page, | ||
| required super.size, | ||
| required super.items, | ||
| required super.isLastPage, | ||
| }); | ||
|
|
||
| BreedsPaginationResponse.fromJson( | ||
| Map<String, dynamic> json, | ||
| ) : page = json['page'] as int, | ||
| size = json['size'] as int, | ||
| items = (json['items'] as List<dynamic>) | ||
| .map((e) => Breed.fromJson(e)) | ||
| .toList(); | ||
|
|
||
| @override | ||
| final int page; | ||
|
|
||
| @override | ||
| final int size; | ||
|
|
||
| @override | ||
| final List<Breed> items; | ||
|
|
||
| @override | ||
| bool operator ==(Object other) { | ||
| if (identical(this, other)) return true; | ||
|
|
||
| return other is BreedsPaginationResponse && | ||
| other.page == page && | ||
| other.size == size; | ||
| } | ||
|
|
||
| @override | ||
| int get hashCode => page.hashCode ^ size.hashCode; | ||
|
|
||
| @override | ||
| Map<String, dynamic> toJson() { | ||
| // TODO: implement toJson | ||
| throw UnimplementedError(); | ||
| } | ||
| ) : super.fromJson(json, (e) => Breed.fromJson(e)); |
There was a problem hiding this comment.
개별 PaginationResponse들이 기본 PaginationResponse들을 기존에 implements 하던 것을 extends 하도록 변경해 불필요하게 반복되는 로직들을 제거했습니다.
There was a problem hiding this comment.
PaginationResponse가 다른 클래스들의 순수한 is-a 관계인 것 같아 상속으로 바꿔도 좋을 것 같습니다!
There was a problem hiding this comment.
불필요하게 반복되는 코드를 줄여보자는 관점으로 접근 했었는데 is-a와 has-a로 extends와 implements를 판단할 수 있군요.
Yellowtoast
suggested changes
Feb 12, 2024
| } | ||
| bool operator ==(Object other) => | ||
| identical(this, other) || | ||
| other is PaginationResponse && |
There was a problem hiding this comment.
요 비교 로직에서 other is PaginationResponse<T> 로 비교하지 않아도 괜찮을까요?
There was a problem hiding this comment.
별 생각없이 IDE 자동 완성 기능으로 작성한 부분이었는데 Generic 타입이 달라도 같은 값이라고 판단하고 있었네요.
Comment on lines
+5
to
+15
| class BreedsPaginationResponse extends PaginationResponse<Breed> { | ||
| BreedsPaginationResponse({ | ||
| required this.page, | ||
| required this.size, | ||
| required this.items, | ||
| required super.page, | ||
| required super.size, | ||
| required super.items, | ||
| required super.isLastPage, | ||
| }); | ||
|
|
||
| BreedsPaginationResponse.fromJson( | ||
| Map<String, dynamic> json, | ||
| ) : page = json['page'] as int, | ||
| size = json['size'] as int, | ||
| items = (json['items'] as List<dynamic>) | ||
| .map((e) => Breed.fromJson(e)) | ||
| .toList(); | ||
|
|
||
| @override | ||
| final int page; | ||
|
|
||
| @override | ||
| final int size; | ||
|
|
||
| @override | ||
| final List<Breed> items; | ||
|
|
||
| @override | ||
| bool operator ==(Object other) { | ||
| if (identical(this, other)) return true; | ||
|
|
||
| return other is BreedsPaginationResponse && | ||
| other.page == page && | ||
| other.size == size; | ||
| } | ||
|
|
||
| @override | ||
| int get hashCode => page.hashCode ^ size.hashCode; | ||
|
|
||
| @override | ||
| Map<String, dynamic> toJson() { | ||
| // TODO: implement toJson | ||
| throw UnimplementedError(); | ||
| } | ||
| ) : super.fromJson(json, (e) => Breed.fromJson(e)); |
There was a problem hiding this comment.
PaginationResponse가 다른 클래스들의 순수한 is-a 관계인 것 같아 상속으로 바꿔도 좋을 것 같습니다!
Yellowtoast
added
merge needed
- is_last_page 적용 - 개별 PaginationResponse가 기본 PaginationResponse를 implements -> extends 하도록 변경
juan-rybczinski
force-pushed
the
feature/85-is-last-page
branch
from
6dfa845
to
49665d4
Compare
juan-rybczinski
added
merge needed
Yellowtoast
approved these changes
Feb 20, 2024
juan-rybczinski
removed
review needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
is_last_page을 적용했습니다.extends하도록 변경했습니다.Type of Change