Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve functionality and performance #13

Merged
merged 26 commits into from
Sep 5, 2024
Merged

Improve functionality and performance #13

merged 26 commits into from
Sep 5, 2024

Conversation

ktevfik
Copy link
Contributor

@ktevfik ktevfik commented Aug 22, 2024

Hello,

I have implemented some improvements to make the application more efficient and seamless. This is my first pull request in Python, and I look forward to your valuable feedback.

Best regards.

@ktevfik
Add OpenAI API key management functions and default parameters in con…
da02920 
…fig.py

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Add unit tests for OpenAI API key configuration functions
f942cc8 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Add unit tests for CLI commands in test_cli.py
20a895a 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Update minimum Python version to 3.12 and configure environment setti…
97e8dbf 
…ngs in tox.ini

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Refactor test_client.py to update tests for generate_response and ini…
c3c82da 
…tialize_openai_client functions

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Refactor OpenAI client to utilize OpenAI API directly and enhance res…
a90083b 
…ponse generation logic.

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Update python_requires to version >=3.12 in setup.cfg
c81f5e1 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Update base requirements to include OpenAI 1.42.0 and remove requests…
8643037 
… and click.

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Update dependencies in requirements/base.txt to latest versions
1745968 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Update CI dependencies in requirements/ci.txt for compatibility and e…
9cffc5f 
…nhancements

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Update dependency versions in requirements/local.txt
8158662 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Refactor CLI for OpenAI interactions: improve model selection and tok…
8974d1b 
…en handling, update completion and repl commands.

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@peterdemin
Copy link
Owner

Thanks, I'll take a look on the weekend

peterdemin
peterdemin reviewed Aug 24, 2024
View reviewed changes
src/openai_cli/cli.py Outdated Show resolved Hide resolved
@peterdemin
Copy link
Owner

Overall, the code looks pretty good for the first time 😉 I find this style of unit tests shallow and does not provide a good safety net, but I won't block the PR on it.
Unfortunately, OpenAI rejects my credit card, and I ran out of credits, so I can't check the new version manually... And I haven't been using it for some time, because I kinda abandoned another project that relied on this. Which makes you the primary user and developer on the project 😆 I'll merge the changes and release the new major version once you're happy with it.

@ktevfik
Copy link
Contributor Author

ktevfik commented Aug 25, 2024

thanks for your reviews. i am going to do corrections asap.

@ktevfik
fix merge conflict
f4c1fd4
@ktevfik
fix merge conflict
8cd9f89
@ktevfik
Replace openai with requests in base requirements.
a22450d 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Remove click from base requirements
c7c630f 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Update package versions in CI requirements
8dc2790 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Update package versions in local requirements
992a85c 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Add support for max tokens and temperature in CLI, with conversation …
dac2ae1 
…history and error handling

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Refactor OpenAI client to use requests.Session and improve error hand…
d530504 
…ling

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Add API_BASE_URL variable to config for OpenAI API endpoint
bddadd0 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Refactor CLI tests to use constants for model parameters and mock API…
5bb7857 
… base URL

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Fix syntax error in OPENAI_API_KEY in tox.ini
6bb84dc 
Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
fix merge conflict
dac5cd3
@ktevfik
Copy link
Contributor Author

ktevfik commented Aug 28, 2024

Hi again, could you please review this when you're available? If it's okay, I'll update the README.md as well. @peterdemin

@ktevfik
Refactor CLI tests to include session mocking and update conversation…
2a70398 
… history assertions

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@ktevfik
Refactor tests in test_client.py to use requests.Session and enhance …
bfc106e 
…error handling

Signed-off-by: Mustafa Tevfik Kadan <mtevfik41@gmail.com>
@peterdemin
Copy link
Owner

Thanks! This is great!

@peterdemin peterdemin merged commit 2a6156e into peterdemin:main Sep 5, 2024
1 of 9 checks passed
@peterdemin
Copy link
Owner

Released 1.0.0: https://pypi.org/project/openai-cli/1.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdemin peterdemin peterdemin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktevfik @peterdemin