-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade for Phalcon V5 and PHP 8 #1535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to setNamespaces() in Tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 5.0.x #1535 +/- ##
========================================
+ Coverage 3.29% 4.40% +1.11%
========================================
Files 111 82 -29
Lines 5101 3995 -1106
========================================
+ Hits 168 176 +8
+ Misses 4933 3819 -1114 |
rudiservo
approved these changes
Aug 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The works checks out, I have tested and generated, the only that is missing is the changelog entry.
I think it can be added after.
niden
approved these changes
Aug 29, 2023
Thank you @escribiendocodigo !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Upgrade Phalcon Devtools to work with Phalcon V5, Phalcon Migration V3 and PHP 8
In raising this pull request, I confirm the following (please check boxes):
Upgrade Guide
Thanks