Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/invalid_config_call Fixed the way Config class was called #1540

Open
wants to merge 1 commit into
base: 5.0.x
Choose a base branch
from

Conversation

abiral
Copy link

@abiral abiral commented Jul 30, 2023

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

The PR consists of the fix where the Dev tool was not compatible with Phalcon version 5.2.3

Thanks

@rudiservo
Copy link
Contributor

@abiral could you change this PR to 5.0.x branch instead of master please?

@abiral abiral changed the base branch from master to 5.0.x August 25, 2023 13:51
@abiral
Copy link
Author

abiral commented Aug 25, 2023

@rudiservo Thanks for the comment. It's done

@rudiservo
Copy link
Contributor

@abiral sorry, we have another PR that has these changes and a lot more that addresses full compatibility with phalcon5 and php8.
Thanks you for your contribution anyway.

@www3b
Copy link

www3b commented Aug 29, 2023

@abiral sorry, we have another PR that has these changes and a lot more that addresses full compatibility with phalcon5 and php8. Thanks you for your contribution anyway.

When will the PR be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants