Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify building rcmd matrix #192

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

galachad
Copy link
Member

This PR is generated matrix before execution.

In the current situation, we were showing the job as complete.

image

With this PR we executed devel only on initial condition.

image

@cicdguy kindly asked for review.

Copy link
Collaborator

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cicdguy
Copy link
Collaborator

cicdguy commented Jul 23, 2024

I don't think @bms63 likes to see this kind of stuff in the PR check status:

Screenshot 2024-07-23 at 7 44 44 AM

I'll leave it for him and others to decide. Technically this is okay for me though.

@galachad
Copy link
Member Author

I don't think @bms63 likes to see this kind of stuff in the PR check status:

Screenshot 2024-07-23 at 7 44 44 AM

I'll leave it for him and others to decide. Technically this is okay for me though.

You are right. I added the name to the job, Create R CMD Check matrix please let me know if you have a different suggestion.

@galachad galachad requested a review from bms63 July 24, 2024 23:00
@bms63
Copy link
Collaborator

bms63 commented Jul 27, 2024

I don't think @bms63 likes to see this kind of stuff in the PR check status:
Screenshot 2024-07-23 at 7 44 44 AM
I'll leave it for him and others to decide. Technically this is okay for me though.

You are right. I added the name to the job, Create R CMD Check matrix please let me know if you have a different suggestion.

Haha yes I prefer if we could hide this step from the developers. We tend to have newer folks to this stuff and it can be a bit overwhelming having so many CI jobs. IS there any way to fold it into the R CMD Check?

However, I must admit I don't understand what the issue that is being solved here? Can someone please explain? We have some others ask for R-CMD checks and worries out snapshots not being checked as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants