Fixes handling of term freqs that are missing or zero #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current database and API returns subsumer terms for which there is no count for certain corpora. Erroneously, the KB API currently returns a zero count for those, when it should return no count. This change should handle both cases, and removes those subsumers from the calculation. Fixes #153.
|
@johnbradley the failure in the release (R 4.x) check is due to phenoscape/phenoscape-kb-services#378. Due to random sub-sampling done in the test, whether the particular test fails or not depends on whether an affected term happens to be in the subsample. @balhoff any idea on ETA for getting this fixed? This is highest priority right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current database and API returns subsumer terms for which there is no count for certain corpora. Erroneously, the KB API currently returns a zero count for those, when it should return no count (phenoscape/phenoscape-kb-services#382). This change should handle both cases, and removes those subsumers from the calculation.
Fixes #153.