Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) - autoclosed #269

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jan 5, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/cyphar/filepath-securejoin v0.2.3 -> v0.2.4 age adoption passing confidence

SecureJoin: on windows, paths outside of the rootfs could be inadvertently produced

GHSA-6xv5-86q9-7xr8 / GO-2023-2048

More information

Details

Impact

For Windows users of github.com/cyphar/filepath-securejoin, until v0.2.4 it was possible for certain rootfs and path combinations (in particular, where a malicious Unix-style /-separated unsafe path was used with a Windows-style rootfs path) to result in generated paths that were outside of the provided rootfs.

It is unclear to what extent this has a practical impact on real users, but given the possible severity of the issue we have released an emergency patch release that resolves this issue.

Thanks to @​pjbgf for discovering, debugging, and fixing this issue (as well as writing some tests for it).

Patches

c121231e1276e11049547bee5ce68d5a2cfe2d9b is the patch fixing this issue. v0.2.4 contains the fix.

Workarounds

Users could use filepath.FromSlash() on all unsafe paths before passing them to filepath-securejoin.

References

See #​9.

Severity

Moderate

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Paths outside of the rootfs could be produced on Windows in github.com/cyphar/filepath-securejoin

GHSA-6xv5-86q9-7xr8 / GO-2023-2048

More information

Details

Certain rootfs and path combinations result in generated paths that are outside of the provided rootfs on Windows.

Severity

Unknown

References

This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).


Release Notes

cyphar/filepath-securejoin (github.com/cyphar/filepath-securejoin)

v0.2.4

Compare Source

This release fixes a potential security issue in filepath-securejoin
when used on Windows (GHSA-6xv5-86q9-7xr8, which could be used to
generate paths outside of the provided rootfs in certain cases), as well
as improving the overall behaviour of filepath-securejoin when dealing
with Windows paths that contain volume names. Thanks to Paulo Gomes for
discovering and fixing these issues.

In addition, we've switched (at long last) to GitHub Actions and have
continuous integration testing on Linux, MacOS, and Windows.

Thanks to the following contributors for making this release possible:

Signed-off-by: Aleksa Sarai cyphar@cyphar.com


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the automated label Jan 5, 2024
@renovate renovate bot changed the title fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) - autoclosed Jan 7, 2024
@renovate renovate bot closed this Jan 7, 2024
@renovate renovate bot deleted the renovate/release-1.13-go-github.com/cyphar/filepath-securejoin-vulnerability branch January 7, 2024 14:24
@renovate renovate bot changed the title fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) - autoclosed fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) Jan 9, 2024
@renovate renovate bot restored the renovate/release-1.13-go-github.com/cyphar/filepath-securejoin-vulnerability branch January 9, 2024 14:24
@renovate renovate bot reopened this Jan 9, 2024
@renovate renovate bot force-pushed the renovate/release-1.13-go-github.com/cyphar/filepath-securejoin-vulnerability branch from 87b5c4f to 39310e6 Compare January 9, 2024 14:26
@renovate renovate bot changed the title fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) - autoclosed Jan 9, 2024
@renovate renovate bot closed this Jan 9, 2024
@renovate renovate bot deleted the renovate/release-1.13-go-github.com/cyphar/filepath-securejoin-vulnerability branch January 9, 2024 14:27
@renovate renovate bot changed the title fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) - autoclosed fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) Jan 16, 2024
@renovate renovate bot restored the renovate/release-1.13-go-github.com/cyphar/filepath-securejoin-vulnerability branch January 16, 2024 13:18
@renovate renovate bot reopened this Jan 16, 2024
@renovate renovate bot force-pushed the renovate/release-1.13-go-github.com/cyphar/filepath-securejoin-vulnerability branch from 39310e6 to 7837f96 Compare January 16, 2024 13:19
@renovate renovate bot changed the title fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) fix(deps): update module github.com/cyphar/filepath-securejoin to v0.2.4 [security] (release-1.13) - autoclosed Jan 17, 2024
@renovate renovate bot closed this Jan 17, 2024
@renovate renovate bot deleted the renovate/release-1.13-go-github.com/cyphar/filepath-securejoin-vulnerability branch January 17, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants