Add void return type in DoctrineSchemaCompilerPass and MessageQueueCollector
#1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
changed the title
void return type in DoctrineSchemaCompilerPassvoid return type in DoctrineSchemaCompilerPass and MessageQueueCollector
|
@makasim This one is ready for review. |
|
@makasim I fixed the CS error. If you approve, it's going to be green. Except for 1 failing test that is out of my control. Could you please merge this? Thanks. |
|
Unfortunately, I cannot merge the red build, If it makes to the main it will stay there for a long time, making the whole idea of testing and CI useless. |
|
Main is already red: https://github.com/php-enqueue/enqueue-dev/commits/master The error on this PR is the same, so that's what I mean. Obviously this PR doesn't create new errors 😅 |
|
I give up. The errors in this PR are unrelated to my changes. |
Fixes this deprecation on Symfony 6.3: ``` Method "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()" might add "void" as a native return type declaration in the future. Do the same in implementation "Enqueue\Doctrine\DoctrineSchemaCompilerPass" now to avoid errors or add an explicit @return annotation to suppress this message. ```
Fixes: ``` Method "Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface::collect()" might add "void" as a native return type declaration in the future. Do the same in implementation "Enqueue\Bundle\Profiler\MessageQueueCollector" now to avoid errors or add an explicit @return annotation to suppress this message. ```
|
This fails because this project uses PHPStan 0.12, which is outdated. It should be updated to PHPStan ^1.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these deprecations on Symfony 6.3: