Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use #[AsCommand] attribute on commands #1317

Closed
wants to merge 4 commits into from
Closed

Use #[AsCommand] attribute on commands #1317

wants to merge 4 commits into from

Commits on Oct 14, 2023

  1. Use #[AsCommand] attribute on commands 

    Fixes the following deprecations:

```json
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Consumption\\ConfigurableConsumeCommand\" class instead.",
    "count": 1
  },
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Client\\ConsumeCommand\" class instead.",
    "count": 1
  },
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Client\\ProduceCommand\" class instead.",
    "count": 1
  },
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Client\\SetupBrokerCommand\" class instead.",
    "count": 1
  },
  {
    "message": "Since symfony/console 6.1: Relying on the static property \"$defaultName\" for setting a command name is deprecated. Add the \"Symfony\\Component\\Console\\Attribute\\AsCommand\" attribute to the \"Enqueue\\Symfony\\Client\\RoutesCommand\" class instead.",
    "count": 1
  },
```
    @ruudk @VincentLanglet
    ruudk authored and VincentLanglet committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    46ecb78 View commit details
    Browse the repository at this point in the history

  2. Run PHPStan on 8.0 

    This way it understands attributes.
    @ruudk @VincentLanglet
    ruudk authored and VincentLanglet committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    d4ad159 View commit details
    Browse the repository at this point in the history

  3. Change PHP version in Docker to 8.2

    @ruudk @VincentLanglet
    ruudk authored and VincentLanglet committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    57498db View commit details
    Browse the repository at this point in the history

  4. Try to fix ci

    @VincentLanglet
    VincentLanglet committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    1e4cebe View commit details
    Browse the repository at this point in the history