Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in RdKafkaProducer:flush() method #1347

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

alexbusu-motork
Copy link

Avoid TypeError in RdKafkaProducer::flush()

Avoid TypeError in `RdKafkaProducer::flush()`
@alexbusu-motork
Copy link
Author

It seems there is an issue with localstack deployment, because after the services are up, one of them (the one on port 4576) shuts down. All of the http requests to service healtcheck curl -i http://localhost:4576/_localstack/health will return 404 🤷
What I've tried is to change the localstack image version, by downgrading and upgrading the patch, minor and major versions, but still no luck in having it working.
I notice that this issue happens in other PRs as well.
@makasim @Steveb-p please help with this issue.

@makasim
Copy link
Member

makasim commented Apr 8, 2024

@makasim @Steveb-p please help with this issue.

I can review PR and merge green one. Release a new version. That's it. So, don't expect me to fix failing CI.

@alexbusu-motork
Copy link
Author

@makasim ok, please let me know - since this is a failing component of testing stage (not related to the code quality/functionality itself) - who could help me with this issue? I mean, who is maintaining the functional tests environment, so we can check together?

@makasim
Copy link
Member

makasim commented Apr 8, 2024

Contributors, like you.

@alexbusu-motork
Copy link
Author

@makasim please run the workflow. I've brought some changes.

@alexbusu
Copy link

@makasim please run the workflow again.

@alexbusu
Copy link

@makasim please run the workflow.

@alexbusu
Copy link

Now the only failing test is Enqueue\SnsQs\Tests\Spec\SnsQsSendToTopicAndReceiveNoWaitFromQueueTest::test():

Failed asserting that null is an instance of interface "Interop\Queue\Message".

https://github.com/php-enqueue/enqueue-dev/actions/runs/9580921964/job/26416695363?pr=1347#step:10:266

@makasim @Steveb-p it's not clear to me why this fails here; it is not failing when I run for the same environment on my local machine. What would you suggest, what should I try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants