Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for set = ? for parser #499

Closed
wants to merge 1 commit into from
Closed

Add support for set = ? for parser #499

wants to merge 1 commit into from

Conversation

BackEndTea
Copy link
Contributor

Fixes: #492

@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d70e65d) 96.61% compared to head (13938da) 96.61%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #499   +/-   ##
=========================================
  Coverage     96.61%   96.61%           
- Complexity     2173     2174    +1     
=========================================
  Files            66       66           
  Lines          5054     5058    +4     
=========================================
+ Hits           4883     4887    +4     
  Misses          171      171
Files Changed Coverage Δ
src/Components/SetOperation.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MauricioFauth added a commit to MauricioFauth/sql-parser that referenced this pull request Sep 26, 2023
@MauricioFauth
Fix using ? as a parameter
74504c5 
- Fixes phpmyadmin#202
- Fixes phpmyadmin#412
- Fixes phpmyadmin#492
- Closes phpmyadmin#499
- Related to phpmyadmin#172

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth mentioned this pull request Sep 26, 2023
Merged
@MauricioFauth MauricioFauth self-assigned this Sep 27, 2023
@MauricioFauth
Copy link
Member

Thank you for your contribution. I fixed the issue in the Expression class when I was investigating another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes left review comments

Assignees

@MauricioFauth MauricioFauth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for SET = ?
3 participants
@BackEndTea @MauricioFauth @williamdes