Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tyephint on SelectStatement::$expr #583

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix tyephint on SelectStatement::$expr #583

merged 1 commit into from
Sep 19, 2024

Conversation

niconoe-
Copy link
Contributor

If you try to parse a query like

SELECT CASE WHEN `VALUE` = 1 THEN `COLUMN_ONE` END;

you will see that SelectStatement::$expr is actually containing a CaseExpression and not an Expression.

@MauricioFauth MauricioFauth merged commit f46b2c8 into phpmyadmin:5.10.x Sep 19, 2024
18 of 19 checks passed
@MauricioFauth MauricioFauth self-assigned this Sep 19, 2024
@MauricioFauth MauricioFauth added this to the 5.10.1 milestone Sep 19, 2024
@niconoe- niconoe- deleted the fix/typehint-select-expr branch September 20, 2024 08:15
@niconoe- niconoe- mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauricioFauth MauricioFauth MauricioFauth approved these changes

Assignees

@MauricioFauth MauricioFauth

Labels
None yet
Projects
None yet
Milestone
5.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@niconoe- @MauricioFauth