Fix check for impure property hooks - #6246
Open
AJenbo wants to merge 2 commits into
Open
Conversation
Member
|
This tells me there's probably something more lacking in this area.
|
Contributor
Author
|
Indeed they where always set to be impure and there was no checks either way when accessed inside pure functions. I implemented the checks for this, with the opposite assumption as methods so that the maybe case doesn't end up being annoying for users. Should I also implement the check from PHPantom that originally found this issue (in another PR)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The closure gathering impure points from a property hook body wrote to
$hookImpurePoints(captured by reference, never initialized), while the code afterward merged in$methodImpurePoints. Property-hook impurity data was silently discarded. Fixed by renaming consistently to$hookImpurePoints.This issue is probably latents since no build in rule consumes
PropertyHookReturnStatementsNode::getImpurePoints()yet.