fix(minify): support minified client packages

[kdubb]

The getArgumentNames function was fixed to resolve a few issues with minification as detailed below.

Whitespace

getArgumentNames tests for specific code pieces but assumes whitespace that may be removed by minification. The tests are changed to use regex’s that make the space optional.

class extend vs class

After minification code arises like the following:

class{constructor(e,t,r,n,i,a,o){this.id=e,this.aliases=t,this.caCertificate=r,this.hash=n,this.inception=i,this.deviceCount=a,this.data=o}}

Notice the lack of extends after class. This causes the class extends test to fail and causes a syntax error for the missing class name. This regex was altered to make the test for extends or the {, which causes replacement with class JacksonClass as required.

Connection with issue(s)

Resolve issue #7

Testing and Review Notes

All test pass.

To Do

Adding proper tests for this scenario requires minifying a client class that uses decorators from this package. Alternatively a number of strings of pre-minified code could be added, testing them against getArgumentNames directly.

For example:

const names = getArgumentNames('class{constructor(e,t,r,n,i,a,o){this.id=e,this.aliases=t,this.caCertificate=r,this.hash=n,this.inception=i,this.deviceCount=a,this.data=o}}')

expect(names).toEqual(['e','t','r','n','I','a','o']);

Which of these methods is best and should be implemented is a decision left for the package maintainer.

[kdubb]

Note that this only fixes the Invalid keyword errors that arise after minification. Minification also renames parameters of functions so some method of manually specifying the parameter is still required.

Our code uses JsonProperty with explicit names (e.g. JsonProperty({ value: 'id' })) so this fixes our issues but this should be noted in the documentation or some method of recovering the argument names that works with minification should be implemented.

[nfonrose]

The fix in this PR solved our deserialization issues (which appeared when switching to a PROD configuration with minification) and this should definitively be merged.

In the meantime, we have to poll from (@outfoxx/jackson-js).

Thank you @kdubb for the fix.
And thank you @pichillilorenzo for jackson-js !