Repackaging & Fixes - #53
Open
Gadgetoid wants to merge 8 commits into
Open
Conversation
- hatchling dynamic optional-dependencies via hatch-requirements-txt - [dependency-groups] dev; ruff import sorting (drop isort/black) - pre-commit + editorconfig; uv-based CI and tox qa - requires-python >= 3.9, classifiers 3.9-3.13 - remove check.sh, requirements-dev.txt, .stickler.yml
Coverage Report for CI Build 33012280955Coverage increased (+5.2%) to 89.621%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
The gasm_valid status bit was folded into data.status but never surfaced, so callers could only check heat_stable.
Answers #46.
get_power_mode returned CONF_T_P_MODE_ADDR unmasked, so it reported 0x8d rather than FORCED_MODE once oversampling was configured. set_power_mode's wait could never block: get_power_mode reassigns self.power_mode as a side effect, so both sides of the comparison were always equal. Masking alone leaves the wait a no-op; removing the aliasing alone spins forever, since FORCED_MODE self-clears to SLEEP_MODE and can never be observed. Only SLEEP_MODE is waited on, and the wait is bounded.
2.0.0 is published; the fixes landed under it by mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.