Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADC(pin) needs to be ADC(machine.Pin(pin)) in recent versions of MicroPython #965

Open
helgibbons opened this issue Jul 2, 2024 · 2 comments
Open

ADC(pin) needs to be ADC(machine.Pin(pin)) in recent versions of MicroPython #965

helgibbons opened this issue Jul 2, 2024 · 2 comments
Assignees
@helgibbons

Comments

@helgibbons
Copy link
Contributor

helgibbons commented Jul 2, 2024 •
edited
Loading

When using high ADC pin numbers, you now need to init ADC(machine.Pin(29)) instead of ADC(29), for example.

As per: https://forums.pimoroni.com/t/pico-lipo-not-reading-battery-voltage/25060/

More info/discussion at micropython/micropython#10947
@helgibbons helgibbons changed the title ADC(29) needs to be ADC(Pin.29) in recent versions of MicroPython ADC(pin) needs to be ADC(machine.Pin(pin)) in recent versions of MicroPython Jul 2, 2024
@helgibbons helgibbons self-assigned this Jul 2, 2024
@helgibbons helgibbons mentioned this issue Jul 2, 2024
Merged
@Gadgetoid
Copy link
Member

I think this might be fixed at the MicroPython level now: micropython/micropython@2b8de74

@helgibbons helgibbons mentioned this issue Oct 25, 2024
Merged
@waffshappen
Copy link
Contributor

waffshappen commented Oct 25, 2024 •
edited
Loading

When using high ADC pin numbers, you now need to init ADC(machine.Pin(29)) instead of ADC(29)

Yep, that fixes the battery voltage reading for me for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helgibbons helgibbons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gadgetoid @waffshappen @helgibbons