Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spritesheets for PenRGB565 #959

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

waffshappen
Copy link
Contributor

I am using a tufty2040 and i wanted to use 565 to show high quality jpegs on my badge, but spritesheets did not work. Simply allowing this and generating a 128x96 Spritesheet (128x128 explodes memory-wise) and using https://github.com/jimmywong2003/PNG-to-RGB565/blob/master/png2rgb565.py with isSWAP=True to create the final spritesheet allows me to have a repeating high quality jpeg character being animated and a high quality spritesheet additionally to show icons, elements and borders.

Please allow this by default, as its the same as the 332 version and it makes my life easier by being able to use regular releases (current main seems to have broken battery reading)

@waffshappen
Copy link
Contributor Author

Is there any Interest in enabling this?

@Gadgetoid
Copy link
Member

Sorry RP2350 and Pico SDK 2.0 stuff have been eating my time. Thank you. This should be enabled in our next release!

@Gadgetoid Gadgetoid added this to the v1.24.0 milestone Aug 18, 2024
@Gadgetoid
Copy link
Member

I have no earthly clue what's happened to the CI here 🤦

Could you possibly rebase and squash your commits into a single change, please?

@waffshappen
Copy link
Contributor Author

Could you possibly rebase and squash your commits into a single change, please?

The ci stuff was leftover from when i disabled all but the tufty to see if builds faster than waiting for all.

Updated to current main and redid it fresh, please check again?

@waffshappen
Copy link
Contributor Author

Note: i tried out the battery.py tufty example again and it still shows a completely bogus voltage reading for the battery on the current micrpython build output, just in case that isnt a known issue yet ^^

@Gadgetoid Gadgetoid merged commit 6ac9bc0 into pimoroni:main Oct 25, 2024
15 checks passed
@Gadgetoid
Copy link
Member

Thank you!

I'm not sure about Tufty's battery.py, but it's probably running into the myriad problems our other battery reading attempts have suffered.

@helgibbons
Copy link
Contributor

Maybe this? #965

#966 is an open PR with some fixed examples (though maybe these changes won't be needed when MicroPython gets a version bump?)

@Gadgetoid Gadgetoid mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants