Add TS types for transports #1050
Conversation
| } | ||
|
|
||
| // ToDo https://github.com/pinojs/thread-stream/issues/24 | ||
| type ThreadStream = any |
There was a problem hiding this comment.
Considering that ThreadStream is at a pre-release version and might potentially change a lot, I don't think it makes much sense to inline its type definitions in pino, especially since it is likely to be simply fed into pino and not manipulated directly.
I'll work on pinojs/thread-stream#24 when there is a green light to do so, and replace this type with a reference to bundled type, but I don't think it should be a blocker here.
|
@mcollina On a somewhat unrelated note, considering that thread-stream is at a pre-release version, shouldn't it be pinned at patch, not minor version, as breaking changes within minor versions are legal within semver? |
|
thread-stream is an internal library that should not be seen from the outside. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
refs #1003