Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing TypeScript types #24

Open
kibertoad opened this issue Jul 3, 2021 · 6 comments
Open

Missing TypeScript types #24

kibertoad opened this issue Jul 3, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@kibertoad
Copy link
Contributor

No description provided.

@kibertoad kibertoad added the enhancement New feature or request label Jul 3, 2021
@kibertoad
Copy link
Contributor Author

@mcollina Is it too early to add types? How much breaking API changes are expected in this package in the nearby future?

@mcollina
Copy link
Member

mcollina commented Jul 4, 2021

go for them!

@castarco
Copy link
Contributor

I'm adding a minimal version of types in this draft PR #71 , but I only added them because I needed types for testing a fix. They're not exposed in the package.json file, nor refined enough.

I prefer to not overdo them for this PR, but I could prepare a second one with a refined version, and expose them properly.

@magnusriga
Copy link

magnusriga commented Aug 21, 2024

@mcollina I noticed that ThreadStream (the return type of transport(..)) is any. Is there a reason we do not just set it to be DestinationStream? That would match with what pino(options: ... , stream: DestinationStream) expects.

@mcollina
Copy link
Member

Because it's not.

@evenfrost
Copy link

@magnusriga thanks with the DestinationStream hint, helped me to fix the any warning 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants