Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[knox]: change client struct #105

Merged
merged 8 commits into from
Mar 6, 2024
Merged

[knox]: change client struct #105

merged 8 commits into from
Mar 6, 2024

Conversation

yoyouwen
Copy link
Contributor

@yoyouwen yoyouwen commented Mar 5, 2024

Use UncacheClient address instead of object

krockpot
krockpot reviewed Mar 5, 2024
View reviewed changes
cmd/dev_client/main.go Outdated Show resolved Hide resolved
@yoyouwen yoyouwen marked this pull request as draft March 5, 2024 23:16
@yoyouwen yoyouwen requested a review from krockpot March 5, 2024 23:32
@yoyouwen yoyouwen marked this pull request as ready for review March 5, 2024 23:40
@yoyouwen yoyouwen requested a review from krockpot March 5, 2024 23:40
@krockpot krockpot merged commit 0a91669 into pinterest:master Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krockpot krockpot Awaiting requested review from krockpot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoyouwen @krockpot