Ignore redirects in middleware

pirsch-analytics · Jul 17, 2022 · 8a083b5 · 8a083b5
1 parent b43612b
commit 8a083b5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [0.4.0] - 2022-07-17
+
+### Changed
+
+- Ignore redirects in middleware.
+
 ## [0.3.2] - 2022-07-17
 
 ### Fixed

diff --git a/src/Http/Middleware/TrackPageview.php b/src/Http/Middleware/TrackPageview.php
@@ -3,15 +3,23 @@
 namespace Pirsch\Http\Middleware;
 
 use Closure;
+use Illuminate\Http\RedirectResponse;
 use Illuminate\Http\Request;
 use Pirsch\Facades\Pirsch;
 
 class TrackPageview
 {
     public function handle(Request $request, Closure $next): mixed
     {
-        Pirsch::track();
-
         return $next($request);
     }
+
+    public function terminate(Request $request, mixed $response): void
+    {
+        if ($response instanceof RedirectResponse) {
+            return;
+        }
+
+        Pirsch::track();
+    }
 }