Fix error running tests on Linux kernel 5.13 or newer #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of torvalds/linux@1b8b208, unsupported ioctls now return ENOTTY instead of EINVAL. This change was also backported to the 5.10 stable branch, so it's a problem on the current release of many Linux distros now.
puellanivis
reviewed
Jan 14, 2022
| @@ -152,7 +153,7 @@ func checktty(t *testing.T, err error) { | |||
| t.Helper() | |||
| // some ioctls fail against char devices if they do not | |||
| // support a particular feature | |||
| if (runtime.GOOS == "darwin" && err == unix.ENOTTY) || (runtime.GOOS == "linux" && err == unix.EINVAL) { | |||
| if ((runtime.GOOS == "darwin" || runtime.GOOS == "linux") && err == unix.ENOTTY) || (runtime.GOOS == "linux" && err == unix.EINVAL) { | |||
There was a problem hiding this comment.
It might make sense to put the (err == unix.EINVAL || err == unix.ENOTTY) together? Or maybe this is getting complex enough, we want to split it up in a switch?
🤷♀️ I mean, the code should work fine either way…
There was a problem hiding this comment.
I don't feel strongly either way. Happy to change it however you'd like, just let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of torvalds/linux@1b8b208, unsupported ioctls now return ENOTTY instead of EINVAL. This change was also backported to the 5.10 stable branch, so it's a problem on the current release of many Linux distros now.