Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tgyuu/#89 #97

Merged
merged 30 commits into from
Jan 11, 2024
Merged

Feature/tgyuu/#89 #97

merged 30 commits into from
Jan 11, 2024

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Jan 9, 2024

1. ๐Ÿ“„ ๊ด€๋ จ๋œ ์ด์Šˆ ๋ฐ ์†Œ๊ฐœ

closed #89

2. ๐Ÿ”ฅ๋ณ€๊ฒฝ๋œ ์ 

- ์ž‘์€ ๊ธฐ๊ธฐ์—์„œ๋„ ํ˜ธํ™˜๋  ์ˆ˜ ์žˆ๋„๋ก Scrollable๋กœ ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค.

- ๋ถˆํ•„์š”ํ•œ Composable๋“ค ๋‹ค ์—†์• ๋ฒ„๋ ธ์Šต๋‹ˆ๋‹ค.

- ์ผ์ • ๊ด€๋ จ ๋ถ€๋ถ„ Management ๋ชจ๋“ˆ์—์„œ Management-Event ๋ชจ๋“ˆ๋กœ ๋ถ„๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค.

3. ๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

ํฐ ํ™”๋ฉด

ํฐ ํ™”๋ฉด



์ž‘์€ ํ™”๋ฉด

์ž‘์€ ํ™”๋ฉด




์ค‘์ฒฉ ์Šคํฌ๋กค์ด ํ•„์š”ํ•œ ์„ค๋ฌธ ๋“ฑ๋ก ์ฒซ ๋ฒˆ์งธ ํŽ˜์ด์ง€ ๋นผ๊ณ ๋Š” ๋‹ค ๋งˆ์Œ์— ๋“ญ๋‹ˆ๋‹ค.

๋ณด์‹œ๋ฉด ํฐ ํ™”๋ฉด์—์„œ ์„ค๋ฌธ ๋“ฑ๋ก ์ฒซ ํŽ˜์ด์ง€ ๋‹ค์Œ ํ™”๋ฉด์œผ๋กœ ๊ฐ€๋Š” ๋ฒ„ํŠผ์ด ํ•˜๋‹จ์— ๋”ฑ ๋ถ™์–ด์žˆ์ง€ ์•Š์•„์š”.

์ด ๋ถ€๋ถ„๋งŒ ์ค‘์ฒฉ์Šคํฌ๋กค์ด๋ผ์„œ ๊ทธ๋Ÿฐ๊ฑด๋ฐ, (๊ด€๋ฆฌ ์ฒซ ํŽ˜์ด์ง€๋Š” LazyColumn์˜ ๋†’์ด๊ฐ€ ์ •ํ•ด์ ธ์žˆ์–ด์„œ ์ƒ๊ด€์—†์–ด์š”)

์ถ”ํ›„์— ๋ฆฌํŒฉํ† ๋ง ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. ๊ธ‰ํ•œ๊ฑด ์•„๋‹ˆ๋ผ์„œ.

4. ๐Ÿ’ก์•Œ๊ฒŒ๋œ ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

์Šคํฌ๋กค ๋˜๊ฒŒ ํ•˜๋Š” ๋ฐฉ๋ฒ•

MyTheme {
        Box(
            modifier = Modifier
                .fillMaxSize()
                .border(2.dp, Color.Green) //for visual effect only
                .verticalScroll(rememberScrollState())
        ) {
            Column(
                modifier = Modifier
                    .fillMaxSize()
                    .padding(2.dp)
                    .border(2.dp, Color.Red) //for visual effect only
            ) {
               //some content
            }
        }
}

์™€ ๊ฐ™์ด verticalScroll() ์—๋‹ค๊ฐ€ scrollState๋ฅผ ๋„ฃ์–ด์ฃผ๋ฉด ๋œ๋‹ค.




์ด ๋•Œ, scrollableํ•˜๊ฒŒ ๋งŒ๋“  Composalbe ๋‚ด๋ถ€์˜ Composable์€ Modifier.fillMaxSize() ๊ฐ€ ๋จน์ง€ ์•Š๋Š”๋‹ค.

์ด๋Ÿด ๊ฒฝ์šฐ ์•„๋ž˜ ์ฝ”๋“œ์™€ ๊ฐ™์ด,

MyTheme {
        Box(
            modifier = Modifier
                .fillMaxSize()
                .border(2.dp, Color.Green) //for visual effect only
                .verticalScroll(rememberScrollState())
                .height(IntrinsicSize.Max)
        ) {
            Column(
                modifier = Modifier
                    .fillMaxSize()
                    .padding(2.dp)
                    .border(2.dp, Color.Red) //for visual effect only
            ) {
               //some content
            }
        }
}

height(IntrinsicSize.Max) ๋ฅผ ์ถ”๊ฐ€ํ•ด์ฃผ๋ฉด fillMaxSize()๊ฐ€ ๊ฐ€๋Šฅํ•ด์ง„๋‹ค.




์ด ํ•ด๊ฒฐ ๋ฐฉ๋ฒ•์€ ๊ฐ„๋‹จํ•˜์ง€๋งŒ, ๋ทฐ ๋‚ด๋ถ€์˜ ๋ชจ๋“  ์ธก์ •์ด ๋‘ ๋ฒˆ ์ˆ˜ํ–‰๋˜๋ฏ€๋กœ ์„ฑ๋Šฅ ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ๋‹ค.

๋ ˆํผ๋Ÿฐ์Šค




ํ˜น์€ ์ปดํฌ์ฆˆ์—์„œ ๊ถŒ์žฅํ•˜์ง€ ์•Š๋Š” ๋ฐฉ์‹์ด์ง€๋งŒ,

BoxWithConstraints(
        modifier = Modifier
            .fillMaxSize()
    ) {
        Column(
            modifier = Modifier
                .heightIn(min = maxHeight)
                .verticalScroll(rememberScrollState())
        ) {
            Spacer(modifier = Modifier.weight(1f)
            Text(text="This is at the bottom")
        }
    }

์™€ ๊ฐ™์ด BoxWithConstraints๋ฅผ ์‚ฌ์šฉํ•œ๋‹ค.

๊ทธ๋ฆฌ๊ณ  ๋‚ด๋ถ€์— heightIn(min = maxHeight)๋ฅผ ๋‘”๋‹ค.




์‚ฌ์‹ค ์ธก์ •์„ ๋‘๋ฒˆํ•˜๋Š” ๊ฑฐ๋‚˜ ์ œ์•ฝ์„ ์‚ฌ์šฉํ•˜๋Š” ๊ฑฐ๋‚˜ ๋‘˜ ๋‹ค ์ปดํฌ์ฆˆ์—์„œ ๊ถŒ์žฅํ•˜๋Š” ์‚ฌํ•ญ์€ ์•„๋‹ˆ๋‹ˆ๊นŒ ๊ฑฐ๊ธฐ์„œ ๊ฑฐ๊ธฐ์ผ์ง€๋„..?

@tgyuuAn tgyuuAn added ๐ŸŽจ์œ ์•„์ด๐ŸŽจ ํ”ผ๊ทธ๋งˆ, ์—‘์„ธ๋ฉœ, ์ปดํฌ์ฆˆ ์œ ์•„์ด/์œ ์—‘์Šค ์ž‘์—… ๐Ÿ”ง๋ฆฌํŒฉํ„ฐ๋ง๐Ÿ”ง ๋ฆฌํŒฉํ„ฐ๋ง์ผ๊นŒ์š” ๋ฆฌํŒฉํ† ๋ง์ผ๊นŒ์š”? ๐Ÿงฉํƒœ๊ทœ๐Ÿงฉ ENFP ์•ˆํƒœ๊ทœ 24์„ธ ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. labels Jan 9, 2024
@tgyuuAn tgyuuAn self-assigned this Jan 9, 2024
@@ -5,6 +5,7 @@
<string name="back_button_description">Back Icon</string>
<string name="sign_in">๋กœ๊ทธ์ธ</string>
<string name="sign_in_email">์ด๋ฉ”์ผ</string>
<string name="wapp_icon_description">WAPP ICON</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ ‘๊ทผ์„ฑ ์ตœ๊ฐ• ์•ฑ ใ„ทใ„ทใ„ทใ„ทใ„ทใ„ทใ„ทใ„ทใ„ทใ„ท

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹

@@ -162,7 +161,7 @@ internal fun EventEditScreen(
modifier = Modifier.padding(top = 16.dp),
)

EventRegistrationContent(
com.wap.wapp.feature.management.event.registration.EventRegistrationContent(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ•ด๋‹น path๋Š” import๋กœ ๋นผ๋Š”๊ฒŒ ๋‚ซ์ง€ ์•Š์„๊นŒ์š” ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

์ˆ˜์ •ํ•ด๋†“๊ฒ ์Šต๋‹ˆ๋‹ค!

Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์–ด์š” ํƒœ๊ทœ์ƒ !

์˜ค๋Š˜ ํ•˜๋ฃจ๋„ ํ˜ธ์•„์ดํ‹ฐ์ด์ž…๋‹ˆ๋‹ท

coroutineScope.launch {
scrollState.scrollTo(0)
}
onNextButtonClicked()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ค์Œ ํ™”๋ฉด์œผ๋กœ ์ „ํ™˜ํ•  ๋•Œ ์Šคํฌ๋กค์„ ์œ„๋กœ ์˜ฌ๋ฆฐ๋‹ค์Œ, ์ „ํ™˜ ํ•˜์‹œ๋Š” ์ด์œ ๊ฐ€ ๋”ฐ๋กœ ์žˆ๋‚˜์š” ?

Copy link
Member Author

@tgyuuAn tgyuuAn Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ผ์ • ๋“ฑ๋ก ๋ฐ ์ˆ˜์ •์˜ ๊ฒฝ์šฐ์—๋Š” ๋‚ด๋ถ€์— LazyColumn์ด ์—†์–ด์„œ,

๊ฐ€์žฅ ์™ธ๊ณฝ์˜ Column์— ์Šคํฌ๋กคํ•˜๊ฒŒ ๋งŒ๋“ค์–ด ๋†“์•˜์–ด์š”.

(์ฆ‰, ํ•˜๋‚˜์˜ Scrollable์„ ์ด์šฉํ•ด์„œ ๋‘ ํŽ˜์ด์ง€๋ฅผ ๋‹ค ์ปค๋ฒ„ ๊ฐ€๋Šฅํ•˜๊ฒŒ ํ–ˆ์–ด์š”.)




๊ทธ๋ ‡๊ธฐ ๋•Œ๋ฌธ์— ๋‹ค์Œ ํŽ˜์ด์ง€๋ฅผ ๋„˜์–ด๊ฐ€๋„ ์Šคํฌ๋กค ํฌ์ปค์‹ฑ์ด ๊ทธ ์ž๋ฆฌ์— ๋จธ๋ฌด๋Š”๋ฐ,

ํŽ˜์ด์ง€๋ฅผ ๋„˜์–ด๊ฐ€๋ฉด ๊ฐ€์žฅ ์œ„์ชฝ์„ ๋ณด๋Š”๊ฒŒ ์ด์ƒ์ ์ด๋ผ์„œ scrollTo๋ฅผ ๋„ฃ์–ด๋†จ์–ด์š”.




(์„ค๋ฌธ ๋“ฑ๋ก ๋ฐ ์ˆ˜์ •์€ ์ฒซ ํŽ˜์ด์ง€ ์ผ์ •์„ ์„ ํƒํ•˜๋Š” ๋ถ€๋ถ„์—์„œ LazyColumn์ด ์‚ฌ์šฉ๋˜์–ด์„œ ๊ทธ๋ ‡๊ฒŒ๋Š” ๋ชปํ–ˆ์–ด์š”.

๊ณต๋ถ€ํ•˜๋ฉด ํ•  ์ˆ˜๋Š” ์žˆ์„ ๊ฒƒ ๊ฐ™์€๋ฐ ์ข€ ์–ด๋ ค์›Œ์„œ ์ง€๊ธˆ๋„ ๊ณต๋ถ€ํ•˜๋Š” ์ค‘์ด์—์š”!)




์„ค๋ฌธ ๋“ฑ๋ก ์ชฝ๋„ NestedScrollConnection ๊ณต๋ถ€๊ฐ€ ๋๋‚˜๋ฉด ๊ฐ๊ฐ์˜ ํŽ˜์ด์ง€์— ์Šคํฌ๋กค ๋‹ฌ๋ ค์žˆ๋˜ ๊ฒƒ์„ ์†Œ๊ฑฐํ•˜๊ณ ,

๊ฐ€์žฅ ์™ธ๊ณฝ์˜ Column์—๋งŒ ์Šคํฌ๋กค์„ ๋‹ฌ๊ณ  ์ €๋ ‡๊ฒŒ ๋‹ค์Œ ํŽ˜์ด์ง€์— ๋„˜์–ด๊ฐ€๋ฉด ScrollTo(0)์„ ํ•ด์„œ ์ƒ๋‹จ์„ ๋ณด๊ฒŒ ํ•  ์ƒ๊ฐ์ด์—์š”!

modifier = Modifier.fillMaxSize(),
verticalArrangement = Arrangement.spacedBy(16.dp),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ธฐ์กด Arrangement.SpaceBetween๊ณผ ์ž‘์„ฑํ•˜์‹  Arrangement.spacedBy(16.dp)๋Š” ์ฐจ์ด๊ฐ€ ํฐ๋ฐ,

Event์™€์˜ UI ํ†ต์ผ ๋•Œ๋ฌธ์— ์ˆ˜์ •ํ•˜์‹  ๊ฑด๊ฐ€์š” ?

Copy link
Member Author

@tgyuuAn tgyuuAn Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceBetween์„ ์‚ฌ์šฉํ•˜์‹  ์ด์œ ๊ฐ€,

ํ•˜๋‹จ์— ๋ฒ„ํŠผ์„ ๋‘๊ธฐ ์œ„ํ•ด์„œ ์‚ฌ์šฉํ•˜์‹  ๊ฒƒ ๊ฐ™๋Š”๋ฐ ๋งž๋‚˜์š”?




์ด๋ ‡๊ฒŒ ViewGroup ๋А๋‚Œ์˜ Column Composable์„ ํ•˜๋‚˜ ๋” ๋‘๋Š” ๋ฐฉ๋ฒ• ๋ณด๋‹ค,

๋‚ด๋ถ€์—

Spacer(modifier = Modifier.weight(1f))

์„ ๋‘๋Š” ๋ฐฉ๋ฒ•์„ ํ†ตํ•ด์„œ ๋‹ค์Œ์œผ๋กœ ๊ฐ€๋Š” ๋ฒ„ํŠผ์„ ํ•˜๋‹จ์— ๊ณ ์ •์‹œ์ผฐ์–ด์š”...!


Indent๋„ ํ•˜๋‚˜ ์ค„๊ณ  ๋” ์ง๊ด€์ ์ธ ๊ฒƒ ๊ฐ™์•„์„œ์š”..!

์ถ”๊ฐ€์ ์ธ ์„ค๋ช…์€ #97 (comment) ์จ๋†จ์Šต๋‹ˆ๋‹ค!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฒ„ํŠผ์„ ์•„๋ž˜์— ๋ฐฐ์น˜ํ•˜๋Š” ๋ชฉ์ ์ด๋ผ๋ฉด, SpaceBetween๊ณผ ํƒœ๊ทœ๋‹˜๊ป˜์„œ ์†Œ๊ฐœํ•˜์‹  ๋ฐฉ๋ฒ•์œผ๋กœ๋„ ๋Œ€์ฒด๊ฐ€ ๊ฐ€๋Šฅํ•  ๊บผ ๊ฐ™์•„์š” !

ํ•˜์ง€๋งŒ, SpaceBetween์€ ์ปดํฌ๋„ŒํŠธ๋ฅผ ์ค‘๊ฐ„์— ๋ฐฐ์น˜ํ•จ์—๋„ ๋ชฉ์ ์ด ์žˆ์–ด์š” ,,!

ํ…Œ๋ธ”๋ฆฟ๊ณผ ๊ฐ™์€ ๊ฒฝ์šฐ๋กœ ํ™”๋ฉด์ด ์„ธ๋กœ๊ฐ€ ๊ธด ๊ฒฝ์šฐ

SpaceBetween์€ ์ค‘๊ฐ„์— ๋ฐฐ์น˜๋˜์ง€๋งŒ,
Spacer์˜ ๊ฒฝ์šฐ์—๋Š” ๊ทธ๋Œ€๋กœ ์ƒํ•˜ ํŒจ๋”ฉ์ด 16dp๋กœ ๊ณ ์ •๋˜์–ด์„œ

A ์ปดํฌ๋„ŒํŠธ

(16dp)

B ์ปดํฌ๋„ŒํŠธ

Spacer(0dp ~ ํ™”๋ฉด์ด ์ปค์ง€๋ฉด ์ปค์งˆ ์ˆ˜๋ก ์ฐจ์ง€ํ•˜๋Š” dp๊ฐ€ ์ฆ๊ฐ€)

๋ฒ„ํŠผ

์ด๋ ‡๊ฒŒ ๊ตฌ์„ฑ๋˜์ง€ ์•Š์„๊นŒ์š” ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

image

A ์ปดํฌ๋„ŒํŠธ

(16dp)

B ์ปดํฌ๋„ŒํŠธ

Spacer(0dp ~ ํ™”๋ฉด์ด ์ปค์ง€๋ฉด ์ปค์งˆ ์ˆ˜๋ก ์ฐจ์ง€ํ•˜๋Š” dp๊ฐ€ ์ฆ๊ฐ€)

๋ฒ„ํŠผ

์ง„ํ˜ธ๋‹˜์ด ๋ง์”€ํ•˜์‹  ๊ฒŒ ์ œ๊ฐ€ ์›ํ•˜๋Š” ๊ตฌํ˜„์ด ๋งž์•„์š”.

ํ…Œ๋ธ”๋ฆฟ์ด๋‚˜ ์›๋ž˜ ๊ธฐ๊ธฐ์—์„œ๋„ ๋‹ค ํ˜ธํ™˜๋˜๋„๋ก Spacer์— Weight๋ฅผ ๋‹จ ๊ฒƒ์ด ๋งž์•„์š”.

ํ”ผ๊ทธ๋งˆ์—๋„ ๊ทธ๋ ‡๊ฒŒ ๋˜์–ด ์žˆ๊ณ ์š”!




์•„์ง SpaceBetween ์„ ์‚ฌ์šฉํ•ด์„œ ์ปดํฌ๋„ŒํŠธ๋ฅผ ์ค‘๊ฐ„์— ๋ฐฐ์น˜ํ•˜๋Š” ๊ฒƒ์ด ๋ชฉ์ ์ด๋‹ค. ๊ฐ€ ์•ฝ๊ฐ„์€ ์ดํ•ด๊ฐ€ ์•ˆ๋˜๋Š”๋ฐ ์ถ”๊ฐ€์ ์ธ ์„ค๋ช… ๊ฐ€๋Šฅํ• ๊นŒ์š”?

์•„๋‹ˆ๋ฉด ์ œ๊ฐ€ ๋†“์น˜๊ณ  ์žˆ๋Š” ๋ถ€๋ถ„์ด ์žˆ๋Š”์ง€๋„ ๊ถ๊ธˆํ•ด์š”.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ง ๊ทธ๋Œ€๋กœ ๋‚ ์งœ์™€ ์‹œ๊ฐ„์„ ์ค‘๊ฐ„์— ๋ฐฐ์น˜ํ•˜๋ ค๊ณ  ํ–ˆ์–ด์š” !

์บฌ์บฌ ์ œ๊ฐ€ ํ”ผ๊ทธ๋งˆ๋ฅผ ์ œ๋Œ€๋กœ ์•ˆ๋ดค๋„ค์š”.

์›ํ•˜์‹œ๋Š” ๊ตฌํ˜„์ด ๋งž๋‹ค๋ฉด ๊ทธ๋Œ€๋กœ ๊ฐ€์ž…์‹œ๋‹ค ~!

Comment on lines 54 to 78
Card(
colors = CardDefaults.cardColors(
containerColor = WappTheme.colors.black25,
),
modifier = Modifier
.fillMaxWidth()
.clickable { onEventSelected(event) },
border = BorderStroke(
color = if (event.eventId == selectedEvent.eventId) {
WappTheme.colors.yellow34
} else {
WappTheme.colors.black25
},
width = 1.dp,
),
) {
Column(
verticalArrangement = Arrangement.spacedBy(8.dp),
modifier = Modifier.padding(16.dp),
) {
Text(
text = event.title,
style = WappTheme.typography.titleBold,
color = WappTheme.colors.white,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด์ „ ํ”ผ์•Œ์—์„œ ์ œ๊ฐ€ ํ•ด๋‹น ๋ถ€๋ถ„์„ ๋”ฐ๋กœ EventCard๋กœ ๋บ๋Š”๋ฐ,

๋”ฐ๋กœ ๋‹ค์‹œ ๋„ฃ์œผ์‹  ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ด์š” ,, !!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ œ๊ฐ€ ์ด์ „์— ์ž‘์„ฑํ•œ ์ฝ”๋“œ์—์„œ๋Š” weight๊ฐ€ ๋“ค์–ด๊ฐ€์žˆ๋Š”๋ฐ,

ํ•ด๋‹น ์ฝ”๋“œ๋Š” weight๊ฐ€ ๋น ์ ธ์žˆ์–ด์š”,

์ด๋ฒคํŠธ์˜ ์ˆ˜๊ฐ€ ๋งŽ์•„์ง€๋ฉด ๋ฒ„ํŠผ์„ ๊ฐ€๋ฆฌ๋Š” ์ผ์ด ๋ฐœ์ƒํ•˜์ง€ ์•Š์„๊นŒ์š” ? (์ด์ „ ์ฝ”๋“œ์—์„œ๋Š” ๋ฒ„ํŠผ์„ ๊ฐ€๋ ค์„œ, ์ œ๊ฐ€ weight๋ฅผ ๋„ฃ์—ˆ์–ด์š”)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด์ „ ํ”ผ์•Œ์—์„œ ์ œ๊ฐ€ ํ•ด๋‹น ๋ถ€๋ถ„์„ ๋”ฐ๋กœ EventCard๋กœ ๋บ๋Š”๋ฐ,

๋”ฐ๋กœ ๋‹ค์‹œ ๋„ฃ์œผ์‹  ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ด์š” ,, !!

์ด ๋ถ€๋ถ„์€ ์ถฉ๋Œ ํ•ด๊ฒฐํ•˜๋‹ค๊ฐ€ ์ƒ๊ธด ์ด์Šˆ์ž…๋‹ˆ๋‹ค!

๋‹ค์‹œ ์ˆ˜์ •ํ•ด๋†“๊ฒ ์Šต๋‹ˆ๋‹ค.

Copy link
Member Author

@tgyuuAn tgyuuAn Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ œ๊ฐ€ ์ด์ „์— ์ž‘์„ฑํ•œ ์ฝ”๋“œ์—์„œ๋Š” weight๊ฐ€ ๋“ค์–ด๊ฐ€์žˆ๋Š”๋ฐ,

ํ•ด๋‹น ์ฝ”๋“œ๋Š” weight๊ฐ€ ๋น ์ ธ์žˆ์–ด์š”,

์ด๋ฒคํŠธ์˜ ์ˆ˜๊ฐ€ ๋งŽ์•„์ง€๋ฉด ๋ฒ„ํŠผ์„ ๊ฐ€๋ฆฌ๋Š” ์ผ์ด ๋ฐœ์ƒํ•˜์ง€ ์•Š์„๊นŒ์š” ? (์ด์ „ ์ฝ”> ๋“œ์—์„œ๋Š” ๋ฒ„ํŠผ์„ ๊ฐ€๋ ค์„œ, ์ œ๊ฐ€ weight๋ฅผ ๋„ฃ์—ˆ์–ด์š”)

์ง€๊ธˆ์€ LazyColumn ๋‚ด๋ถ€์— ๊ฐ€์žฅ ํ•˜๋‹จ์— item์ด๋ผ๋Š” ์Šค์ฝ”ํ”„์— ๋ฒ„ํŠผ์ด ๋”ฐ๋กœ ๋“ค์–ด๊ฐ€์žˆ์–ด์„œ,

๋ฆฌ์‚ฌ์ดํด๋Ÿฌ๋ทฐ๊ฐ€ ๋ฒ„ํŠผ์„ ๊ฐ€๋ฆฌ๋Š” ์ผ์€ ๋ฐœ์ƒํ•˜์ง€ ์•Š์•„์š”. ํ•ญ์ƒ ๋ฆฌ์‚ฌ์ดํด๋Ÿฌ๋ทฐ ์•„๋ž˜์ชฝ์— ๋ฒ„ํŠผ์ด ์œ„์น˜ํ•˜๊ฒŒ ๋ฉ๋‹ˆ๋‹ค...!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ธฐ์กด Colum์ด๋ž‘ ๋‹ค๋ฅด๊ตฐ์š” ,, ์ข‹์€ ์ง€์‹ ๋ฐฐ์›Œ๊ฐ‘๋‹ˆ๋‹ค

๊ทธ๋Ÿผ ๋งŒ์•ฝ์— EventList๊ฐ€ ์ปค์ง€๋ฉด, ์–ด๋–ป๊ฒŒ ๋˜๋‚˜์š” ??

weight๊ณผ ๋งˆ์ฐฌ๊ฐ€์ง€๋กœ ํฌ๊ธฐ๊ฐ€ ์ž๋™์œผ๋กœ ๋‚˜๋จธ์ง€ ๋ถ€๋ถ„์„ ์ฐจ์ง€ํ•˜๊ฒŒ ๋˜๊ณ  ,
๊ทธ ์•ˆ์—์„œ๋„ ์ค‘์ฒฉ์Šคํฌ๋กค์ด ๋˜๋„๋ก ๋ณ€๊ฒฝ๋˜๋‚˜์š” ?

Copy link
Member Author

@tgyuuAn tgyuuAn Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

๊ทธ๋ƒฅ ๋ฆฌ์‚ฌ์ดํด๋Ÿฌ๋ทฐ๋กœ ์น˜๋ฉด ๋˜ ๋‹ค๋ฅธ ViewHolder๋ฅผ ์‚ฌ์šฉํ•ด์„œ View๋ฅผ ๋ฐฐ์น˜ํ•œ๋‹ค๊ณ  ์ƒ๊ฐํ•˜์‹œ๋ฉด ๋ผ์š”.

ํ•ญ์ƒ ํ•˜๋‹จ์— ๋ฐฐ์น˜๋˜์–ด์š”.

๊ทธ๋ž˜์„œ EventList๊ฐ€ ๋งŽ์„ ๊ฒฝ์šฐ ์Šคํฌ๋กค์„ ํ•ด์•ผ์ง€๋งŒ ๋ฒ„ํŠผ์„ ๋ณผ ์ˆ˜ ์žˆ์–ด์š”.

๋‹ค๋ฅธ ์ชฝ UI๋„ ๋‹ค์Œ ํŽ˜์ด์ง€๋กœ ๋„˜์–ด๊ฐ€๋Š” ํ˜น์€ ์™„๋ฃŒ ๋ฒ„ํŠผ์ด ์Šคํฌ๋กค์„ ํ•ด์•ผ์ง€ ๋ณผ ์ˆ˜ ์žˆ์–ด์š”.

๊ทธ๊ฒŒ ๋” ์ž์—ฐ์Šค๋Ÿฌ์šด ๊ฒƒ ๊ฐ™๊ธฐ๋„ ํ•˜๊ณ ์š”.




์ด๋ ‡๊ฒŒ ๊ตฌํ˜„ํ–ˆ์„ ๋–„์˜ ๋‹จ์ ์€ EventList๊ฐ€ ํด ๋•Œ๊ฐ€ ์•„๋‹Œ ์ž‘์„ ๋•Œ ๋ฒ„ํŠผ์ด ํ•˜๋‹จ์— ์•ˆ ๋ถ™๋Š” ๋‹ค๋Š” ์ ์ด์—์š”.

๊ทธ๋ž˜์„œ PR์— ์ด ๋ถ€๋ถ„์„ ์–ธ๊ธ‰ํ–ˆ์–ด์š”.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ ์ „์ฒด๋ฅผ ๋ชฉ๋ก์œผ๋กœ ๋งŒ๋“œ๋‹ˆ, ํƒœ๊ทœ๋‹˜์ด ๋ง์”€ํ•˜์‹  ๋ฐฉ๋ฒ•๋Œ€๋กœ ๋  ๊ฒƒ ๊ฐ™๋„ค์š” !!

๊ทผ๋ฐ ์ €๋Š” ๋ฒ„ํŠผ์ด ์•„๋ž˜๋ถ€๋ถ„์— ์•ˆ๋ถ™๋Š” ๊ฒƒ๋„ ์žˆ๋Š”๋ฐ,
๋ชฉ๋ก์ด ์ปค์กŒ์„ ๋•Œ ๋ฒ„ํŠผ์ด ๋ฐ”๋กœ ์•ˆ๋ณด์ด๋Š”๊ฒŒ ์ œ์ผ ํฐ ๊ฒƒ ๊ฐ™์•„์š”.

์ฒ˜์Œ ์‚ฌ์šฉํ•˜๋Š” ์‚ฌ์šฉ์ž๋ผ๋ฉด, ๋ฒ„ํŠผ์ด ์Šคํฌ๋กคํ•ด์•ผ ๋ณด์ด๋Š” ๊ฑธ ์•Œ๊ธฐ ์‰ฝ์ง€ ์•Š์„ ๊ฒƒ ๊ฐ™์•„์„œ์š”ใ… 

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

์ฒ˜์Œ ์‚ฌ์šฉํ•˜๋Š” ์‚ฌ์šฉ์ž๋ผ๋ฉด, ๋ฒ„ํŠผ์ด ์Šคํฌ๋กคํ•ด์•ผ ๋ณด์ด๋Š” ๊ฑธ ์•Œ๊ธฐ ์‰ฝ์ง€ ์•Š์„ ๊ฒƒ ๊ฐ™์•„์„œ์š”ใ… 

์ด ๋ง์— ๋™์˜ํ•ฉ๋‹ˆ๋‹ค!

์›๋ž˜๋Œ€๋กœ ๋Œ๋ ค๋†“๊ฒ ์Šต๋‹ˆ๋‹ค!!!

@@ -44,88 +46,86 @@ internal fun SurveyQuestionContent(
val scrollState = rememberScrollState()

Column(
verticalArrangement = Arrangement.spacedBy(32.dp),
modifier = Modifier.verticalScroll(scrollState),
verticalArrangement = Arrangement.spacedBy(10.dp),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ค๋ฅธ Deadline, Event๋Š” 16dp์ธ๋ฐ, ํ•ด๋‹น ํ™”๋ฉด๋งŒ 10dp๋กœ ์„ค์ •ํ•œ ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š” ??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋ฆฌ๊ณ  ๊ธฐ์กด 32dp์™€ ์ฐจ์ด๊ฐ€ ๊ผฌ ใ…ใ…ใ…ใ…ใ…ใ…ใ…ใ… ํฌ๋„ค์š” ์บฌ์บฌ์บฌ์บฌ์บฌ์บฌ,,,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ค๋ฅธ Deadline, Event๋Š” 16dp์ธ๋ฐ, ํ•ด๋‹น ํ™”๋ฉด๋งŒ 10dp๋กœ ์„ค์ •ํ•œ ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ> > ์š” ??

์ด ๋ถ€๋ถ„๋„ ์‹ค์ˆ˜์ธ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค..

์ˆ˜์ •ํ•ด๋†“๊ฒ ์Šต๋‹ˆ๋‹ค!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ๋ฆฌ๊ณ  ๊ธฐ์กด 32dp์™€ ์ฐจ์ด๊ฐ€ ๊ผฌ ใ…ใ…ใ…ใ…ใ…ใ…ใ…ใ… ํฌ๋„ค์š” ์บฌ์บฌ์บฌ์บฌ์บฌ์บฌ,,,

Figma์— ๊ทธ๋ ค์ง„ UI๋Œ€๋กœ ๋งˆ์ง„์„ ์ž…ํ˜”์Šต๋‹ˆ๋‹ค...!

๊ธฐ์กด์—๋Š” ๊ฐ€์žฅ ์™ธ๊ณฝ์˜ Column์—์„œ ์‚ฌ์ด 32.dp๋กœ ์ฃผ๊ณ  ๋‚ด๋ถ€์— ๋˜ ๋‹ค๋ฅธ ๊ฐ„๊ฒฉ์„ ๊ฐ€์ง„ Column์„ ์ด์šฉํ•ด์„œ ๊ฐ„๊ฒฉ์„ ์กฐ์ ˆํ–ˆ๋‹ค๋ฉด,

๋ถˆํ•„์š”ํ•œ Column์„ ์†Œ๊ฑฐํ•˜๊ณ  ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ๋งˆ์ง„์€ Modifier.padding()์œผ๋กœ ํ•ด๊ฒฐํ•˜์˜€์Šต๋‹ˆ๋‹ค...!

) {
WappTitle(
title = stringResource(R.string.survey_question_title),
content = stringResource(R.string.survey_question_content),
modifier = Modifier.padding(top = 10.dp, bottom = 30.dp),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด์นœ๊ตฌ๋„ ๋งˆ์ฐฌ๊ฐ€์ง€๋กœ์š” !

๋‹ค๋ฅธ ์ปดํฌ์ €๋ธ” ํ•จ์ˆ˜๋Š” top 10, bottom 24์ธ๋ฐ, ๋‹ค๋ฅด๊ฒŒ ์„ค์ •๋˜์–ด ์žˆ์–ด์š” !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜์ •ํ•˜๊ฒ ์”๋‹ˆ๋‹ท!

Copy link
Member Author

@tgyuuAn tgyuuAn Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

์ด๊ฒŒ ๋‹ค์‹œ ๋ณด๋‹ˆ๊นŒ,

ํ”ผ๊ทธ๋งˆ ๋งˆ์ง„์ด 10dp๋กœ ์„ค์ •๋˜์–ด ์žˆ์—ˆ์–ด์š”.

ํ˜น์‹œ ์ด๊ฑฐ ํ”ผ๊ทธ๋งˆ์— UI๋ฐฐ์น˜๊ฐ€ ์ž˜๋ชป๋˜์–ด ์žˆ๋Š” ๊ฒƒ์ผ๊นŒ์š”?

image

verticalArrangement = Arrangement.spacedBy(10.dp),

์— ๋Œ€ํ•œ ์ฝ”๋ฉ˜ํŠธ์˜€์”๋‹ˆ๋‹ค!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜คํ˜ธ์ž‡ ์ œ๊ฐ€ ํ”ผ๊ทธ๋งˆ๋ฅผ ์ œ๋Œ€๋กœ ๋ชป๋ณธ๊ฑฐ๊ตฐ์š” ,, !

๊ทธ๋Œ€๋กœ ๊ฐ€์ž…์‹œ๋‹ค ~~

type = questionType,
)

Spacer(modifier = Modifier.weight(1f))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacer์˜ ์—ญํ• ์ด ์–ด๋–ป๊ฒŒ ๋ ๊นŒ์š” ??

Copy link
Member Author

@tgyuuAn tgyuuAn Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacer๋Š” ๋ง ๊ทธ๋Œ€๋กœ ๋นˆ๊ณต๊ฐ„์„ ์ฑ„์›Œ์ฃผ๋Š” ์—ญํ• ์ž…๋‹ˆ๋‹ค.

๊ธฐ์กด์—์„œ๋Š” ๋ฒ„ํŠผ์„ ํ•˜๋‹จ์— ๋ฐฐ์น˜ํ•˜๊ธฐ ์œ„ํ•ด์„œ

Column {
    Column(Modifier.weight(1f)) {
        /*..*/
    }
    Button() {
    }
}

์„ ์ด์šฉํ•ด์„œ ๋‚ด๋ถ€ Column ์ž์ฒด๋ฅผ ๊ฝ‰์ฑ„์šฐ๋Š” ๋ฐฉ๋ฒ•์„ ์ป๋”๋ผ๋ฉด,

Spacer๋ฅผ ์ด์šฉํ•˜๋ฉด ์™ธ๋ถ€ Column์„ ์†Œ๊ฑฐํ•˜๊ณ ,

Column {
    // ํ•„์š”ํ•œ Composalbe๋“ค

    Spacer(modifier  = Modifier.weight(1f)) // ๋‚จ์€ ๊ณต๊ฐ„์„ ๊ฝ‰ ์ฑ„์›€

    Button() {    }  // ํ•˜๋‹จ์— ๋ฒ„ํŠผ์„ ๋ฐฐ์น˜
}

๋กœ ๋ฐ”๊ฟ€ ์ˆ˜ ์žˆ์–ด์š”!




Box ๋ฅผ ์ด์šฉํ•ด์„œ๋„ ์ฑ„์šธ ์ˆ˜ ์žˆ์ง€๋งŒ,

Box๋Š” xml๋กœ ์น˜๋ฉด FrameLayout๋А๋‚Œ์ด๊ณ ,

Spacer๋Š” xml์—์„œ View ๋А๋‚Œ์ด๋ผ๊ณ  ๋ณด๋ฉด ๋  ๊ฒƒ ๊ฐ™์•„์š”.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€ ํŒ ์•Œ์•„๊ฐ‘๋‹ˆ๋‹ค์ž‡~~

fun setSurveyDateDeadline(date: LocalDate) { _surveyDateDeadline.value = date }
fun setSurveyDateDeadline(date: LocalDate) {
_surveyDateDeadline.value = date
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ˆ๋ฌด ViewModel์ด ๊ธธ์–ด์ ธ์„œ, ๋‹ค ํ•œ์ค„๋กœ ๊ตฌ์„ฑํ–ˆ๋Š”๋ฐ, ๊ทธ๋Ÿฌ๋ฉด ์•ˆ๋˜๋Š” ๊ฑธ๊นŒ์š” ,,, ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

์•„๋‡จ ๊ทธ๊ฒƒ์€ ์ž์œ ์ž…๋‹ˆ๋‹ค.

์ด๊ฑฐ ์•„๋งˆ๋„ ์ œ ๋…ธํŠธ๋ถ์—์„œ Ctrl+L ๋ˆŒ๋Ÿฌ์„œ ์ž๋™์œผ๋กœ ๋ฐ”๋€ ๊ฒƒ ๊ฐ™์•„์š”!

Comment on lines 213 to 215
private fun clearSurveyQuestionState() {
_surveyQuestion.value = EMPTY
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ๋‘์šฉ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

๋‹ค์‹œ ์ˆ˜์ •ํ•ด๋†“์„๊นŒ์š”?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

๋‹ค์‹œ ์ˆ˜์ •ํ–ˆ์”๋‹ˆ๋‹ค!

@jeongjaino jeongjaino added โœ๏ธ์ˆ˜์ • ์š”์ฒญโœ๏ธ ์ฝ”๋“œ ๋ฆฌ๋ทฐํ›„ ์ฝ”๋“œ ์ˆ˜์ • ์š”์ฒญ ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. and removed ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. labels Jan 11, 2024
@jeongjaino
Copy link
Member

์ „๋ฐ˜์ ์œผ๋กœ ์ €๋Š” ๋‚ด๋ถ€ ์ˆ˜์ง ๊ฐ„๊ฒฉ์„ 32dp๋กœ ํ–ˆ๋Š”๋ฐ,
ํƒœ๊ทœ์ƒ์€ ๋‹ค 16dp๋กœ ์„ค์ •ํ•˜์…จ๋„ค์š”.. ! ๋‚˜์ค‘์— ์ด์•ผ๊ธฐ ํ•œ๋ฒˆ ํ•ด๋ณด๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” ,, ใ… ใ…  (์ €๋Š” ๋ฌด์กฐ๊ฑด 32ํŒŒ๋ผ,,)

Comment on lines 33 to 36
LazyColumn(
verticalArrangement = Arrangement.spacedBy(16.dp),
modifier = Modifier.fillMaxSize(),
) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํƒœ๊ทœ๋‹˜ ์ด๋ ‡๊ฒŒ ๊ตฌ์„ฑํ•˜๋ฉด,

์ด๋ฒคํŠธ ๋ชฉ๋ก์˜ ํฌ๊ธฐ์— ๋”ฐ๋ผ์„œ, ํ™”๋ฉด์˜ ๋†’์ด๋ฅผ ๋‹ค ๋ชป์ฑ„์šธ ์ˆ˜๋„ ์žˆ์ง€ ์•Š์„๊นŒ์š” ??

์ด๋ฒคํŠธ๊ฐ€ ํ•˜๋‚˜์ธ ๊ฒฝ์šฐ์— ๋งจ ๋ฐ‘์˜ ๋ฒ„ํŠผ์ด ์ค‘๊ฐ„์— ์˜ค๋Š” ๊ฒฝ์šฐ๋Š” ์—†์„๊นŒ์š” ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฐ”๋กœ ์ง€์ ํ•ด์ฃผ์‹  ๋ถ€๋ถ„์ด

์ œ๊ฐ€ PR์— ์จ๋†“์•˜๋˜ ๋ถ€๋ถ„์ธ๋ฐ์š”,

image




์ด๊ฑธ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•ด์„œ๋Š” ์ค‘์ฒฉ ์Šคํฌ๋กคํ•˜๋Š” ๋ฐฉ๋ฒ•์„ ๊ณต๋ถ€ํ•ด์•ผ ํ•˜๋Š”๋ฐ, ์ง€๊ธˆ ์—ด์‹ฌํžˆ ํ•˜๊ณ  ์žˆ๋Š” ์ค‘์ž…๋‹ˆ๋‹ค...!

์†”์งํžˆ ์Šคํƒ ์˜ค๋ฒ„ ํ”Œ๋กœ์šฐ ์ฝ”๋“œ๋ณด๊ณ  ๋ฐ”๋กœ ์ ์šฉํ•  ์ˆ˜ ์žˆ๋Š”๋ฐ,

์›๋ฆฌ๋ฅผ ๋ชจ๋ฅธ ์ฑ„ ์ ์šฉํ•˜๋Š” ๊ฒŒ ๋งˆ์Œ์— ์•ˆ๋“ค์–ด์„œ ์ดํ•ดํ•˜๋ ค๊ณ  ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

์ถ”ํ›„์— ์ˆ˜์ •ํ• ๊ฒŒ์š”!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฒซ๋ฒˆ์งธ ํ™”๋ฉด์„ ์ค‘์ฒฉ ์Šคํฌ๋กค์„ ํ•ด์•ผ ํ•  ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š” ??

์ค‘๊ฐ„์˜ ๋ ˆ์ด์ง€ ์ปฌ๋Ÿผ์€ ์Šคํฌ๋กค์ด ํ•„์š”ํ•˜๊ฒ ์ง€๋งŒ,

๋‚˜๋จธ์ง€ ๋‘ ๊ฐœ์˜ ์ปดํฌ๋„ŒํŠธ Title, Button์ด ํ™”๋ฉด์—์„œ ํฌ๊ฒŒ ์ฐจ์ง€ํ•˜๋Š” ๋ถ€๋ถ„์€ ์•„๋‹ˆ๋ผ๊ณ  ์ƒ๊ฐํ•ด์š”

๊ทธ๋ž˜์„œ ์ €๋Š” ์ „์ฒด ํ™”๋ฉด์€ fillMaxSize + SpaceAround (๋งจ์œ„ ํƒ€์ดํ‹€, ๋งจ ์•„๋ž˜ ๋ฒ„ํŠผ ๋ฐฐ์น˜ ์œ„ํ•จ) + List(๋‹จ๋…์œผ๋กœ weight)์œผ๋กœ ๊ตฌํ˜„ํ–ˆ์–ด์š” !

ํ•ด๋‹น ๋ฐฉ๋ฒ•๋„ ๊ณ ๋ คํ•ด๋ณด์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”

Copy link
Member Author

@tgyuuAn tgyuuAn Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

๊ทธ๋ ‡๊ฒŒ ๊ตฌํ˜„ํ•˜๋ฉด ๋งค์šฐ ํŽธ๋ฆฌํ•˜๊ธด ํ•ด์š”!

๋‹ค๋ฅธ UI์ชฝ๋„ ์Šคํฌ๋กค ํ•ด์•ผ์ง€๋งŒ ๋ฒ„ํŠผ์ด ๋‚˜์˜ค๊ฒŒ ๋˜์–ด์žˆ์–ด์„œ

ํ•ด๋‹น ํ™”๋ฉด๋„ ์Šคํฌ๋กค์ด ๋ชจ๋‘ ๋œ ๋’ค์— ๋ฒ„ํŠผ์ด ๋‚˜์˜ค๋„๋ก ํ†ต์ผ์‹œํ‚ค๋ ค๊ณ  ๊ทธ๋ ‡๊ฒŒ ํ–ˆ์–ด์š”.




๊ทธ๋ ‡๊ฒŒ ๊ตฌํ˜„ํ•˜๋Š” ๊ฒƒ์ด ๊ฐœ๋ฐœ์ ์œผ๋กœ ๋” ํŽธ๋ฆฌํ•˜๊ธด ํ•ฉ๋‹ˆ๋‹ค.

์ด ํŽ˜์ด์ง€๋Š” ๊ทธ๋ ‡๊ฒŒ ๊ตฌํ˜„ํ•˜๊ณ  ์ถ”ํ›„์— ๊ณต๋ถ€๊ฐ€ ์™„๋ฃŒ๋˜๋ฉด ๋‹ค์‹œ ๋ฆฌํŒฉํ† ๋ง ํ• ๊นŒ์š”?!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ ์ „์ฒด๋ฅผ ๋ชฉ๋ก์œผ๋กœ ๋งŒ๋“œ๋‹ˆ, ํƒœ๊ทœ๋‹˜์ด ๋ง์”€ํ•˜์‹  ๋ฐฉ๋ฒ•๋Œ€๋กœ ๋  ๊ฒƒ ๊ฐ™๋„ค์š” !!

๊ทผ๋ฐ ์ €๋Š” ๋ฒ„ํŠผ์ด ์•„๋ž˜๋ถ€๋ถ„์— ์•ˆ๋ถ™๋Š” ๊ฒƒ๋„ ์žˆ๋Š”๋ฐ, ๋ชฉ๋ก์ด ์ปค์กŒ์„ ๋•Œ ๋ฒ„ํŠผ์ด ๋ฐ”๋กœ ์•ˆ๋ณด์ด๋Š”๊ฒŒ ์ œ์ผ ํฐ ๊ฒƒ ๊ฐ™์•„์š”.

์ฒ˜์Œ ์‚ฌ์šฉํ•˜๋Š” ์‚ฌ์šฉ์ž๋ผ๋ฉด, ๋ฒ„ํŠผ์ด ์Šคํฌ๋กคํ•ด์•ผ ๋ณด์ด๋Š” ๊ฑธ ์•Œ๊ธฐ ์‰ฝ์ง€ ์•Š์„ ๊ฒƒ ๊ฐ™์•„์„œ์š”ใ… 

ํ•ด๋‹น ์˜๊ฒฌ๊ณผ ๋งˆ์ฐฌ๊ฐ€์ง€๋กœ,, ์ €๋Š” ์ด์ „ ๋ฐฉ์‹์— ํ•œํ‘œ ๋˜์ง€๊ฒ ์Šต๋‹ˆ๋‹ค ์บฌ์บฌ์บฌ์บฌ (ํƒœ๊ทœ๋‹˜ ๋ฌดํ•œ์œผ๋กœ ์ผ ๋งŒ๋“ค์–ด๋ฒ„๋ฆฌ๊ธฐ)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

๊ทผ๋ฐ ์ƒ๊ฐํ•ด๋ณด๋‹ˆ ์ €๋„ ์ด๊ฒŒ ๋งž๋Š” ๊ฒƒ ๊ฐ™๋„ค์š”!

๋‹ค์‹œ ์ˆ˜์ •ํ•ด๋†“๊ฒ ์Šต๋‹Œ๋‹ค!

@jeongjaino
Copy link
Member

ํƒœ๊ทœ์ƒ!!

์ด๊ฒŒ ์ œ ์ž‘์—… ๋ถ€๋ถ„์ด๋ผ ๊ฝค ์ง์„ค์ ์œผ๋กœ ๋”ฅํ•˜๊ฒŒ ๋ฆฌ๋ทฐ ๋‚จ๊ธธ์ˆ˜ ๋ฐ–์— ์—†๋Š” ์  ์ดํ•ด๋ถ€ํƒ๋“œ๋ ค์š” ใ… ใ… 

@tgyuuAn
Copy link
Member Author

tgyuuAn commented Jan 11, 2024

@jeongjaino

๊ดœ์ฐฎ์Šต๋‹ˆ๋‹ค. ์ œ ๋ถˆ์ฐฐ์ž…๋‹ˆ๋‹ค ใ…‹ใ…‹ใ…‹

์ „๋ฐ˜์ ์œผ๋กœ ์ €๋Š” ๋‚ด๋ถ€ ์ˆ˜์ง ๊ฐ„๊ฒฉ์„ 32dp๋กœ ํ–ˆ๋Š”๋ฐ,

ํƒœ๊ทœ์ƒ์€ ๋‹ค 16dp๋กœ ์„ค์ •ํ•˜์…จ๋„ค์š”.. ! ๋‚˜์ค‘์— ์ด์•ผ๊ธฐ ํ•œ๋ฒˆ ํ•ด๋ณด๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” ,, ใ… ใ…  (์ €๋Š” ๋ฌด์กฐ๊ฑด 32ํŒŒ๋ผ,,)

์ €๋Š” ์ตœ๋Œ€ํ•œ ํ”ผ๊ทธ๋งˆ UI์— ๋งˆ์ง„์„ ๋ณด๊ณ  ์„ค์ •ํ–ˆ์–ด์š”.

ํ˜น์‹œ 32๋กœ ๋”ฐ๋กœ ์„ค์ •ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ๋Š”์ง€ ๊ถ๊ธˆํ•ด์š”!

@jeongjaino
Copy link
Member

@jeongjaino

๊ดœ์ฐฎ์Šต๋‹ˆ๋‹ค. ์ œ ๋ถˆ์ฐฐ์ž…๋‹ˆ๋‹ค ใ…‹ใ…‹ใ…‹

์ „๋ฐ˜์ ์œผ๋กœ ์ €๋Š” ๋‚ด๋ถ€ ์ˆ˜์ง ๊ฐ„๊ฒฉ์„ 32dp๋กœ ํ–ˆ๋Š”๋ฐ,
ํƒœ๊ทœ์ƒ์€ ๋‹ค 16dp๋กœ ์„ค์ •ํ•˜์…จ๋„ค์š”.. ! ๋‚˜์ค‘์— ์ด์•ผ๊ธฐ ํ•œ๋ฒˆ ํ•ด๋ณด๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” ,, ใ… ใ…  (์ €๋Š” ๋ฌด์กฐ๊ฑด 32ํŒŒ๋ผ,,)

์ €๋Š” ์ตœ๋Œ€ํ•œ ํ”ผ๊ทธ๋งˆ UI์— ๋งˆ์ง„์„ ๋ณด๊ณ  ์„ค์ •ํ–ˆ์–ด์š”.

ํ˜น์‹œ 32๋กœ ๋”ฐ๋กœ ์„ค์ •ํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ๋Š”์ง€ ๊ถ๊ธˆํ•ด์š”!

ํ”ผ๊ทธ๋งˆ ์•ˆ๋ณธ ์ œ์ž˜๋ชป์ž…๋‹ˆ๋‹ค ใ…  ํ”ผ๊ทธ๋งˆ ๋Œ€๋กœ ๊ฐ€์ž…์‹œ๋‹ค !!

@tgyuuAn tgyuuAn removed the ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. label Jan 11, 2024
@jeongjaino jeongjaino added ๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. and removed โœ๏ธ์ˆ˜์ • ์š”์ฒญโœ๏ธ ์ฝ”๋“œ ๋ฆฌ๋ทฐํ›„ ์ฝ”๋“œ ์ˆ˜์ • ์š”์ฒญ labels Jan 11, 2024
@tgyuuAn tgyuuAn merged commit a90fafe into develop Jan 11, 2024
@tgyuuAn tgyuuAn deleted the feature/tgyuu/#89 branch February 6, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. ๐ŸŽจ์œ ์•„์ด๐ŸŽจ ํ”ผ๊ทธ๋งˆ, ์—‘์„ธ๋ฉœ, ์ปดํฌ์ฆˆ ์œ ์•„์ด/์œ ์—‘์Šค ์ž‘์—… ๐Ÿ”ง๋ฆฌํŒฉํ„ฐ๋ง๐Ÿ”ง ๋ฆฌํŒฉํ„ฐ๋ง์ผ๊นŒ์š” ๋ฆฌํŒฉํ† ๋ง์ผ๊นŒ์š”? ๐Ÿงฉํƒœ๊ทœ๐Ÿงฉ ENFP ์•ˆํƒœ๊ทœ 24์„ธ
Projects
None yet
2 participants