Adds ESLint #4
Merged
Adds ESLint #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is using the new ESLint syntax I think it would be better to stick with our own @playcanvas/eslint-config which is eslint v8 for now until we decide to update everything to v9. |
|
@kpal81xd valid. updated to eslint8 using @playcanvas/eslint-config |
kpal81xd
reviewed
Aug 16, 2024
.eslintrc
Outdated
| ], | ||
| "rules": { | ||
| "no-unused-expressions": "off", | ||
| "prefer-arrow-callback": "off", |
There was a problem hiding this comment.
We should leave this on 😅 its better to encourage use of arrow callbacks so the context is clear when using this
There was a problem hiding this comment.
This is for mocha https://mochajs.org/#arrow-functions, have added exception for tests only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ESLint to the repo, fixes relevant linting issues and adds a linting CI step on push/PR