Add unit tests #261
Merged
Add unit tests #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yak32
approved these changes
Jan 18, 2023
ellthompson
approved these changes
Jan 20, 2023
|
I'd like to contribute to this, when will this be merged ? If you like jsdom, and rollup, may I recommend an existing framework (recommended by both on their front page) that gracefully wraps both ? |
|
@epreston Y'know, there's no decent reason why I never merged this. Actually, it was sort of a little experiment because I wanted to give the new Node.js built-in test runner a try. I'll merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to add unit testing for PCUI, based on Node's brand new (v18+) test runner and jsdom.
These tests barely scratch the surface of the API but is meant to be a starting framework into which more tests can be written over time. The tests are now run as part of our GitHub Actions.