Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React export fix #349

Merged
merged 3 commits into from
Feb 23, 2024
Merged

React export fix #349

merged 3 commits into from
Feb 23, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Feb 23, 2024 •
edited
Loading

Fixes #345

  • Changed export prop in package.json from main to import

@kpal81xd kpal81xd self-assigned this Feb 23, 2024
@kpal81xd kpal81xd added the bug Something isn't working label Feb 23, 2024
@willeastcott
Copy link
Contributor

Doesn't this mean we have to reopen this: #330

@kpal81xd
Copy link
Contributor Author

kpal81xd commented Feb 23, 2024 •
edited
Loading

Doesn't this mean we have to reopen this: #330

I seemed to get no linting issues with React PCUI components Ill do some more testing though.

@kpal81xd
Copy link
Contributor Author

@willeastcott found the fix you have to use import instead of main

willeastcott
willeastcott approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. 👍

@kpal81xd kpal81xd merged commit 7aca5ff into main Feb 23, 2024
6 checks passed
@kpal81xd kpal81xd deleted the react-export-fix branch February 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No known conditions for "./react" specifier in "@playcanvas/pcui" package error during build
2 participants
@kpal81xd @willeastcott