Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar styles #357

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Scrollbar styles #357

merged 2 commits into from
Jun 18, 2024

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Jun 18, 2024

This PR has PCUI define appropriate scrollbar styling.

Here are some comparisons of scrollbar styling across Chrome (Safari looks the same) and Firefox:

No styling:

Chrome Firefox
scrollbars-chrome-none scrollbars-firefox-none

CSS Scrollbars Styling Module Level 1:

Chrome Firefox
scrollbars-chrome-standard scrollbars-firefox-standard

WebKit Psuedo-Element styling:

Chrome Firefox
scrollbars-chrome-webkit N/A
line

Despite hover/selection color differences, the WebKit styling seems to look most similar to the Firefox scrollbars which use the standardized CSS properties. So this is what this PR implements.

@willeastcott willeastcott added the enhancement New feature or request label Jun 18, 2024
@willeastcott willeastcott self-assigned this Jun 18, 2024
@willeastcott willeastcott merged commit 4e1cc36 into main Jun 18, 2024
6 checks passed
@willeastcott willeastcott deleted the scrollbar-styles branch June 18, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants