Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: In shadow DOM, The target obtained is shadowRoot #359

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: In shadow DOM, The target obtained is shadowRoot #359

merged 1 commit into from
Sep 6, 2024

Conversation

missingtears
Copy link
Contributor

image

@willeastcott
Copy link
Contributor

Hi. Thanks very much for this pull request. I'm not quite sure what this is addressing. Can you provide a little more detail please?

@missingtears
Copy link
Contributor Author

When I use SelectInput in the Web Components component and select the dropdown option, it cannot update the current value value. Because evt.target obtains the shadowRoot, not the select option, it is closed. By modifying it, it can be obtained in both the shadow DOM and outside;

@missingtears
Copy link
Contributor Author

image

@missingtears
Copy link
Contributor Author

image

@willeastcott willeastcott merged commit cc58b94 into playcanvas:main Sep 6, 2024
6 checks passed
@willeastcott
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@missingtears @willeastcott