Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for slider input events #362

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Fix for slider input events #362

merged 4 commits into from
Oct 1, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Sep 30, 2024

Register move and up pointer events on the correct DOM element instead of relying on global window.

@slimbuck slimbuck added the bug Something isn't working label Sep 30, 2024
@slimbuck slimbuck requested a review from a team September 30, 2024 09:52
@slimbuck slimbuck self-assigned this Sep 30, 2024
willeastcott
willeastcott approved these changes Sep 30, 2024
@slimbuck
Copy link
Member Author

slimbuck commented Oct 1, 2024

Weird, your comment doesn't appear on the ticket here for some reason but I saw it in the email notification. It turns out setPointerCapture was being used already and we just need to register callback on the same DOM element for this to work. I've made the change.

@slimbuck slimbuck changed the title Use capture phase for slider pointer events Fix for slider input events Oct 1, 2024
@willeastcott
Copy link
Contributor

Ok cool. Looks good.

@slimbuck
Copy link
Member Author

slimbuck commented Oct 1, 2024

Added styling changes so cursor looks correct while dragging.

@slimbuck slimbuck merged commit 0151c8c into main Oct 1, 2024
6 checks passed
@slimbuck slimbuck deleted the slider-capture branch October 1, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants