Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add background color picker #243

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Add background color picker #243

merged 3 commits into from
Oct 28, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Oct 28, 2024 •
edited
Loading

Fixes: #215

This PR:

  • adds a color selector for the background to the VIEW OPTIONS panel
Screenshot 2024-10-28 at 15 28 34

Notes:

  • the selected background color isn't currently saved. this should be done along with all the other settings
  • the background color is used when taking screenshots
  • the pcui color picker box is placed awkwardly and only hides itself when clicking on the parent panel

@slimbuck slimbuck added the enhancement New feature label Oct 28, 2024
@slimbuck slimbuck requested a review from a team October 28, 2024 15:31
@slimbuck slimbuck self-assigned this Oct 28, 2024
@slimbuck slimbuck mentioned this pull request Oct 28, 2024
Closed
willeastcott
willeastcott approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, but it's so weird how the picker is offset like that. Did this break it: playcanvas/pcui#354

@slimbuck
Copy link
Member Author

Submitted playcanvas/pcui#365 to fix the niggles

@slimbuck slimbuck merged commit a7f2dc4 into playcanvas:main Oct 28, 2024
2 checks passed
@slimbuck slimbuck deleted the bgclr-dev branch October 28, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom canvas background color
2 participants
@slimbuck @willeastcott