Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added _ as a replacement for kind name #537

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

garethahealy
Copy link
Contributor

with the latest release of regal, it adds a check for to make sure the package names matches the path.

My paths have traditionally included a - and the package (which doesn't allow -) uses _. with this new check, I've made the paths match the packages but that then means the generated name for templates is invalid.

this PR adds _ to the replacement list for names

@garethahealy
Copy link
Contributor Author

can see this new regal check would trigger your examples as well, i.e.: https://github.com/plexsystems/konstraint/blob/main/examples/container-deny-added-caps/src.rego#L22

@garethahealy
Copy link
Contributor Author

@jalseth ; good to merge?

Copy link
Collaborator

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jalseth jalseth merged commit 0c240fe into plexsystems:main Sep 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants