Added CreditUsed Report and CreditTicket Report #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Thanks for everithing already done. does this report focntion still working? because i tried to add it without success, tried to check code but i'm not really good as php ;( regards |
|
Can you rebase you branch develop to be compatible with glpi 9.4 Best regards |
xacobofg
force-pushed
the
feature/add_reports
branch
from
e565188
to
cd0a5da
Compare
|
Hello. |
|
Will be great to add the possibility to search tickets with credits criteria. |
cedric-anne
requested review from
a team,
Rom1-B,
AdrienClairembault and
stonebuzz
and removed request for
a team,
stonebuzz,
Rom1-B and
AdrienClairembault
Rom1-B
requested changes
Feb 22, 2024
| $LANG['creditused'][5]="Number ticket"; | ||
| $LANG['creditused'][6]="Entity"; | ||
| $LANG['creditused'][7]="Active"; | ||
| $LANG['creditused_nulo'][0]="None"; |
There was a problem hiding this comment.
I suppose it's a typo?
Suggested change
| $LANG['creditused_nulo'][0]="None"; | |
| $LANG['creditused_null'][0]="None"; |
| include ("../../../../inc/includes.php"); | ||
|
|
||
| $report= new PluginReportsAutoReport($LANG['plugin_credit']['creditused']); | ||
| //Filtro fecha |
| $report->setColumns([new PluginReportsColumn('id', $LANG['creditused'][5]), | ||
| new PluginReportsColumn('ticket', $LANG['creditused'][0]), | ||
| new PluginReportsColumn('active', $LANG['creditused'][7]), | ||
| new PluginReportsColumn('categoria', $LANG['creditused'][1]), |
There was a problem hiding this comment.
Suggested change
| new PluginReportsColumn('categoria', $LANG['creditused'][1]), | |
| new PluginReportsColumn('category', $LANG['creditused'][1]), |
stonebuzz
requested changes
Feb 22, 2024
| //Filtro fecha | ||
| new PluginReportsDateIntervalCriteria($report, 'date', $LANG['creditused_criteria'][0]); | ||
| //Filtro activo | ||
| $choices = [0=>'--', 2 =>$LANG['creditused_active'][1], 1 => $LANG['creditused_active'][0]]; |
There was a problem hiding this comment.
Suggested change
| $choices = [0=>'--', 2 =>$LANG['creditused_active'][1], 1 => $LANG['creditused_active'][0]]; | |
| $choices = [ | |
| 0 => '--', | |
| 2 => $LANG['creditused_active'][1], | |
| 1 => $LANG['creditused_active'][0], | |
| ]; |
| inner join glpi_plugin_credit_entities as gpce on gpce.id=gpct.plugin_credit_entities_id | ||
| inner JOIN `glpi_entities` as ge ON (`gpce`.`entities_id` = `ge`.`id`) | ||
| ".getEntitiesRestrictRequest(" WHERE", "gpce"); | ||
| if ($filter_active->getParameterValue()==2) { |
There was a problem hiding this comment.
Suggested change
| if ($filter_active->getParameterValue()==2) { | |
| if ($filter_active->getParameterValue() == 2) { |
|
|
||
| $report= new PluginReportsAutoReport($LANG['plugin_credit']['creditvoucher']); | ||
| //Filtro Activo | ||
| $choices = [0=>'--', 2 =>$LANG['creditvoucher_active'][1], 1 => $LANG['creditvoucher_active'][0]]; |
There was a problem hiding this comment.
Suggested change
| $choices = [0=>'--', 2 =>$LANG['creditvoucher_active'][1], 1 => $LANG['creditvoucher_active'][0]]; | |
| $choices = [ | |
| 0 => '--', | |
| 2 => $LANG['creditvoucher_active'][1], | |
| 1 => $LANG['creditvoucher_active'][0], | |
| ]; |
| left join glpi_plugin_credit_tickets as pct on (`pct`.`plugin_credit_entities_id` = `gpce`.`id`) | ||
| inner JOIN `glpi_entities` as ge ON (`gpce`.`entities_id` = `ge`.`id`)". | ||
| getEntitiesRestrictRequest(" WHERE", "gpce"); | ||
| if ($filter_active->getParameterValue()==2) { |
There was a problem hiding this comment.
Suggested change
| if ($filter_active->getParameterValue()==2) { | |
| if ($filter_active->getParameterValue() == 2) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreditUsed Report: lists each credit spent.
CreditTicket Report: lists each credit voucher information.
old pull request #23
#34