ci: extract reusable validation workflow shared by PR CI and release … - #334
Open
clanzhang wants to merge 1 commit into
Open
ci: extract reusable validation workflow shared by PR CI and release …#334clanzhang wants to merge 1 commit into
clanzhang wants to merge 1 commit into
Conversation
…ocket-stack#182) Split the test gates that were inlined in release.yml into a reusable workflow (.github/workflows/validate.yml) called by both a new PR CI workflow (ci.yml) and the release workflow. Fixes from the previous attempt (pocket-stack#303): - Add a dedicated wasm job with dtolnay/rust-toolchain + wasm32-unknown-unknown target so that bun tools/wasm.ts no longer fails with a missing target. The wasm artifact is uploaded once and downloaded by js / goldens / tape / docs. - Fix the Rust matrix: move cache-target into the matrix include list and use the boolean matrix.workspace directly instead of comparing it to the string "true", which caused --workspace to be silently dropped and the wrong target directory to be cached. - Bump checkout to v7 and cache to v6 to match release.yml. Closes pocket-stack#182.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the test gates that were inlined in
release.ymlinto a reusableworkflow (
validate.yml) called by both a new PR CI workflow (ci.yml)and the release workflow. This addresses the feedback on #303.
Fixes from #303
wasm32-unknown-unknownnot installed —jsjob and all downstream jobs failwasmjob installs the target viadtolnay/rust-toolchain@stable, uploads the artifact, and downstream jobs download ittruewith string"true"—--workspacesilently dropped, wrong cache pathcache-targetinto the matrixincludelist; usematrix.workspace && '--workspace' || ''directlycheckout@v4/cache@v4drifted fromrelease.ymlv7/v6to matchvalidate.ymlcalled by bothci.ymlandrelease.ymlJob graph
wasm ──┬── js (bun test + tsc)
rust (core / workspace / symbian) ← independent, no wasm needed
Not included (by design)
Closes #182.