[Application] Add missing (un)staking events #867
+5,123
−1,087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me as_type --response params
… name as_type --response params
…/application * refactor/testutil/filter-events: chore: rename testevents import refactor: simplify testevents.FilterEvents() [Code Health] refactor: share helpers to consolidate avoid dependency cycles (#855) [Tooling, Docs] Refactor params docs generation command & update params docs (#864) [On-Chain] Refactor `uint64` type individual param update logic (#863) [Service] Refresh service module params logic (#861) [Proof] Refresh proof module params logic (#851) [Shared] Refresh shared module params logic (#852)
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 867) |
github-actions
bot
added
devnet
push-image
bryanchriswhite
changed the base branch from
refactor/testutil/filter-events
to
main
red-0ne
reviewed
Oct 15, 2024
bryanchriswhite
commented
Oct 15, 2024
bryanchriswhite
commented
Oct 15, 2024
bryanchriswhite
commented
Oct 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
greatheart2
approved these changes
Oct 15, 2024
(cherry picked from commit 85c8e11500838a6271fc570ff7545ef1d22cccc1)
Co-authored-by: red-0ne <red-0ne@users.noreply.github.com>
bryanchriswhite
commented
Oct 16, 2024
x/application/keeper/msg_server_undelegate_from_gateway_test.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds:
EventApplicationStakeEventApplicationUnbondingBeginEventApplicationUnbondingEndEventApplicationUnbondingCanceledRefactors application min. stake unbonding to re-use existing unbonding period and end-blocker mechanics instead of unbonding immediately.
Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist