Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to SDK 1.14 #381

Merged
merged 30 commits into from
Jul 29, 2024
Merged

Update to SDK 1.14 #381

merged 30 commits into from
Jul 29, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jul 14, 2024 •
edited
Loading

Updating the runtimes to SDK version 1.14. CHANGELOG mentions all relevant changes for UI and Wallet builders.

@ggwpez
Update to 1.14
6fa5130 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update Collectives
d99131f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Disable Encointer runtime
ec4914b 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update Kusama coretime
4143885 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update Treasury
1c0af2d 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Update collectives
7fed1b4 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Mock weights
0265664 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@s0me0ne-unkn0wn s0me0ne-unkn0wn mentioned this pull request Jul 15, 2024
Merged
s0me0ne-unkn0wn and others added 6 commits July 17, 2024 13:49
@s0me0ne-unkn0wn
Kusama coretime revenue integration (#384)
36c9a7f 
Based on #381 

CC @ggwpez
@clangenb
re-enable & bump encointer to polkadot-v1.14.0 (#385)
6ca6fcb 
Simply updates the encointer-pallets to v1.14.0. Nothing else happened
there in the meantime. cc @brenzi
@ggwpez
Clippy
0be46e0 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/main' into oty-update-1-14
af19be5
@ggwpez
Update CHANGELOG
b0b1a81 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Clippy
4104b17 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review July 17, 2024 13:11
@ggwpez
Clippy
235d14e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@kianenigma kianenigma mentioned this pull request Jul 17, 2024
Merged
@ggwpez
Fixes
b2be560 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix changelog
30d1345 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
joepetrowski
joepetrowski reviewed Jul 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
seadanda
seadanda approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@seadanda seadanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs benchmarks to be re-run in a few places but from what I understand that's usually done for everything in a separate PR before release. Is that right?

@seadanda seadanda mentioned this pull request Jul 18, 2024
Merged
@s0me0ne-unkn0wn

This comment was marked as resolved.

Sign in to view
@ggwpez
Copy link
Member Author

ggwpez commented Jul 18, 2024

Looks like we're missing a tiiiiny bit of on-demand Coretime – the relay chain part 😅 Somehow I was sure it should be there already. I'll prepare the PR.

They are on this branch though?!

runtimes/relay/kusama/src/lib.rs

Line 1308 in 30d1345

type BrokerPotLocation = BrokerPot;

@s0me0ne-unkn0wn

This comment was marked as resolved.

Sign in to view
seadanda and others added 2 commits July 18, 2024 16:40
@seadanda
Re-enable request_revenue_info_at in CoretimeInterface (#393)
e3fca1e 
In the update to [sdk
1.14](#381) the
`request_revenue_info` is now implemented but this call had been
switched off when it was added in
#212.

This PR just enables this again in the coretime interface.

cc @ggwpez @s0me0ne-unkn0wn
@ggwpez
Merge remote-tracking branch 'origin/main' into oty-update-1-14
9740965
@github-actions github-actions bot requested a review from seadanda July 26, 2024 11:17
@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

1 similar comment
@github-actions GitHub Actions
Copy link

Review required! Latest push from author must always be reviewed

@ggwpez ggwpez mentioned this pull request Jul 26, 2024
Open
@ggwpez
Link issue numbers to TODOs
9b1529e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/main' into oty-update-1-14
e3b2d53
@ggwpez
Post merge fixup
cce6316 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
fmt
b74a51f 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Try to make XCM runtime API compile
d84c74a 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix benchmark
b912cd0 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix benchmarks
6c529ef 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Jul 26, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) July 26, 2024 21:33
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@seadanda seadanda mentioned this pull request Jul 29, 2024
Closed
@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@fellowship-merge-bot fellowship-merge-bot bot merged commit 9d9f164 into main Jul 29, 2024
44 checks passed
@ggwpez ggwpez deleted the oty-update-1-14 branch July 29, 2024 23:53
@ggwpez ggwpez restored the oty-update-1-14 branch July 30, 2024 12:55
fellowship-merge-bot bot pushed a commit that referenced this pull request Aug 8, 2024
@tdimitrov @seadanda @joepetrowski
Enable Coretime on Polkadot Relay (#401)
b52f7de 
Redo of #354 on top of
#381

TODOs:
- [ ] Check migrations with chopsticks
- [ ] Regenerate weights

---------

Co-authored-by: eskimor <eskimor@no-such-url.com>
Co-authored-by: Dónal Murray <donalm@seadanda.dev>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@ggwpez ggwpez mentioned this pull request Aug 9, 2024
Closed
tigerwee

This comment was marked as spam.

Sign in to view

@ggwpez ggwpez deleted the oty-update-1-14 branch August 20, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seadanda seadanda seadanda approved these changes

@tigerwee tigerwee tigerwee left review comments

@bkchr bkchr bkchr approved these changes

@muharem muharem muharem approved these changes

@s0me0ne-unkn0wn s0me0ne-unkn0wn s0me0ne-unkn0wn approved these changes

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

@eskimor eskimor Awaiting requested review from eskimor

@kianenigma kianenigma Awaiting requested review from kianenigma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ggwpez @s0me0ne-unkn0wn @eskimor @kianenigma @bkchr @muharem @seadanda @joepetrowski @tigerwee @clangenb