Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test names #399

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Improve test names #399

merged 1 commit into from
Jul 24, 2024

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jul 24, 2024

The name of the "All changelog tests passing" was clashing with the name of the "All tests passing" test.

Give the check features test a name.

Both changes are required to mark these tests as required in github.

  • Does not require a CHANGELOG entry

The name of the "All changelog tests passing" was clashing with the name of the "All tests passing" test.

Give the check features test a name.

Both changes are required to mark these tests as required in github.
@@ -50,7 +50,7 @@ jobs:
# If you add more jobs, remember to add them to the "needs" array.
confirmChangelogChecksPassed:
runs-on: ubuntu-latest
name: All tests passed
name: All changelog tests passed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also coming here: #397

@ggwpez
Copy link
Member

ggwpez commented Jul 24, 2024

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 5fa4ff0 into main Jul 24, 2024
49 of 53 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@ggwpez ggwpez deleted the bkchr-test-names branch July 24, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants