Improve test names #399
Merged
Improve test names #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the "All changelog tests passing" was clashing with the name of the "All tests passing" test. Give the check features test a name. Both changes are required to mark these tests as required in github.
xlc
approved these changes
Jul 24, 2024
bkontur
reviewed
Jul 24, 2024
| @@ -50,7 +50,7 @@ jobs: | |||
| # If you add more jobs, remember to add them to the "needs" array. | |||
| confirmChangelogChecksPassed: | |||
| runs-on: ubuntu-latest | |||
| name: All tests passed | |||
| name: All changelog tests passed | |||
There was a problem hiding this comment.
this is also coming here: #397
bkontur
approved these changes
Jul 24, 2024
acatangiu
approved these changes
Jul 24, 2024
eskimor
approved these changes
Jul 24, 2024
davxy
approved these changes
Jul 24, 2024
koute
approved these changes
Jul 24, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the "All changelog tests passing" was clashing with the name of the "All tests passing" test.
Give the check features test a name.
Both changes are required to mark these tests as required in github.