Asset Hubs: auto incremented asset id for trust backed assets #414
Conversation
| @@ -1080,6 +1059,11 @@ pub type Migrations = ( | |||
| frame_support::migrations::RemovePallet<DmpQueueName, RocksDbWeight>, | |||
| pallet_collator_selection::migration::v2::MigrationToV2<Runtime>, | |||
| cumulus_pallet_xcmp_queue::migration::v5::MigrateV4ToV5<Runtime>, | |||
| pallet_assets::migration::next_asset_id::SetNextAssetId< | |||
There was a problem hiding this comment.
@joepetrowski still needs to delete MAX_PRIME :P
There was a problem hiding this comment.
|
/merge |
|
@anaelleltd this needs to be communicated to asset issuers. |
|
Enabled Available commands
For more information see the documentation |
Failed to update PR ❌There was an error while trying to keep this PR You may have conflicts More info in the logs 📋 |
As indicated in step 6 of the guidelines re: Runtime release process, the author of the PR should indicate:
cc @muharem |
Failed to update PR ❌There was an error while trying to keep this PR You may have conflicts More info in the logs 📋 |
Failed to update PR ❌There was an error while trying to keep this PR You may have conflicts More info in the logs 📋 |
fellowship-merge-bot
bot
merged commit c125f5c
into
polkadot-fellows:main
|
I have update a description with more information for clients. @bkchr @joepetrowski should we include this into 1.3? If we are going to cut it form master, it is already included. We trying to understand with @anaelleltd if we should notify the clients already. |
|
Yeah it will be included from master. |
I am starting to move some reasonable items to being in #364. Is this a reasonable one to also move over? |
|
@kianenigma you mean as I dynamic parameter? I think no, we do not need it to be a dynamic paramater |
Let's make sure these steps that need to be done by the PR author are part of a PR template? |
No, I mean a runtime API to get the next available AssetId, abstracting over where this storage live, and what its semantics are. |
Setup auto incremented asset id to `50_000_000` for trust backed assets. In order to align with Polkadot/Kusama Asset Hub - polkadot-fellows/runtimes#414 The next closes existing assets IDs in Rococo is `69_696_969`, in Westend is `88_228_866`. ### Migration **Stakeholders**: all clients providing asset creation functionality on Westend/Rococo Asset Hub This change does not break the API but introduces a new constraint. It implements an auto-incremented ID strategy for Trust-Backed Assets (50 pallet instance indexes on both networks), starting at ID 50,000,000. Each new asset must be created with an ID that is one greater than the last asset created. The next ID can be fetched from the `NextAssetId` storage item of the assets pallet. An empty `NextAssetId` storage item indicates no constraint on the next asset ID and can serve as a feature flag for this release.
Setup auto incremented asset id to
50_000_000for trust backed assets.Migration
Stakeholders: all clients providing asset creation functionality on Polkadot/Kusama Asset Hub
This change does not break the API but introduces a new constraint. It implements an auto-incremented ID strategy for Trust-Backed Assets (50 pallet instance indexes on both networks), starting at ID 50,000,000. Each new asset must be created with an ID that is one greater than the last asset created. The next ID can be fetched from the
NextAssetIdstorage item of the assets pallet. An emptyNextAssetIdstorage item indicates no constraint on the next asset ID and can serve as a feature flag for this release.