Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to fix coretime state #458

Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
8b09d7f
Add migration to fix coretime state (WIP)
seadanda Sep 20, 2024
d210d8d
Update timeslice
seadanda Sep 21, 2024
64770cc
Update timeslice
seadanda Sep 21, 2024
4dd1326
Fix compilation without `try-runtime` feature
tdimitrov Sep 23, 2024
0367a60
Remove hardcoded core ids and obtain them from sales instead
tdimitrov Sep 23, 2024
ddf33fc
Remove a duplicated `use`
tdimitrov Sep 23, 2024
79d2e8f
Revert "Remove hardcoded core ids and obtain them from sales instead"
tdimitrov Sep 24, 2024
63b534b
Fix todos and update try-runtime tests
tdimitrov Sep 27, 2024
a0a2ff3
Basic migration logic.
Sep 29, 2024
d98f0e6
fmt
Sep 29, 2024
0f809df
Fix tests
Sep 29, 2024
3349c15
Add useful traces
Sep 29, 2024
aaf3fe0
Add missing tests:
Sep 29, 2024
b5a58d0
Fix imports
Sep 29, 2024
641e72f
Replace remaining useless debug_asserts
Sep 29, 2024
ac10dc3
New lines
Sep 29, 2024
41b53cb
More checks
Sep 29, 2024
e697de8
Cleanup
Sep 29, 2024
73d2256
Merge pull request #6 from eskimor/rk-coretime-migration-fix
eskimor Sep 29, 2024
74e4efc
Fixes, cleanup
Sep 29, 2024
3bfd626
Merge branch 'rk-coretime-migration-fix' into donal-coretime-migratio…
Sep 29, 2024
91076d7
Fix feature propagation
Sep 29, 2024
5b6d997
Add weights
Sep 30, 2024
cb57ec5
Add Changelog entry
Sep 30, 2024
6bc0754
Merge remote-tracking branch 'origin/main' into donal-coretime-migrat…
Sep 30, 2024
8075c6a
Add rpc node for polkadot-coretime so tests are run.
Sep 30, 2024
836feb6
Merge branch 'main' into donal-coretime-migration-fix
eskimor Oct 1, 2024
483c1a2
Update CHANGELOG.md
bkchr Oct 1, 2024
a1acf1c
Update CHANGELOG.md
bkchr Oct 1, 2024
50d429b
Merge branch 'main' into donal-coretime-migration-fix
fellowship-merge-bot[bot] Oct 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/runtimes-matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"name": "coretime-polkadot",
"package": "coretime-polkadot-runtime",
"path": "system-parachains/coretime/coretime-polkadot",
"uri": "wss://polkadot-coretime-rpc.polkadot.io:443",
"is_relay": false
},
{
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
### Fixed

- Chain-spec generator: propagate the `on_chain_release_build` feature to the chain-spec generator. Without this the live/genesis chain-specs contain a wrongly-configured WASM blob ([polkadot-fellows/runtimes#450](https://github.com/polkadot-fellows/runtimes/pull/450)).
- Adds a migration to the Polkadot Coretime chain to fix an issue from the initial Coretime migration. [polkadot-fellows/runtimes#458](https://github.com/polkadot-fellows/runtimes/pull/458)
bkchr marked this conversation as resolved.
Show resolved Hide resolved

### Added

Expand All @@ -24,7 +25,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Fixed

- Kusama: Revert accidental changes to inflation formula ([polkadot-fellows/runtimes#445](tps://github.com/polkadot-fellows/runtimes/pull/445)).
- Kusama: Revert accidental changes to inflation formula ([polkadot-fellows/runtimes#445](https://github.com/polkadot-fellows/runtimes/pull/445)).

## [1.3.1] 23.08.2024

Expand Down
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions system-parachains/coretime/coretime-polkadot/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ pallet-transaction-payment = { workspace = true }
pallet-transaction-payment-rpc-runtime-api = { workspace = true }
pallet-utility = { workspace = true }
sp-api = { workspace = true }
sp-arithmetic = { workspace = true }
sp-block-builder = { workspace = true }
sp-consensus-aura = { workspace = true }
sp-core = { workspace = true }
Expand Down Expand Up @@ -131,6 +132,7 @@ std = [
"serde",
"serde_json/std",
"sp-api/std",
"sp-arithmetic/std",
"sp-block-builder/std",
"sp-consensus-aura/std",
"sp-core/std",
Expand Down
4 changes: 3 additions & 1 deletion system-parachains/coretime/coretime-polkadot/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
include!(concat!(env!("OUT_DIR"), "/wasm_binary.rs"));

mod coretime;
mod migrations;
// Genesis preset configurations.
pub mod genesis_config_presets;
#[cfg(test)]
Expand Down Expand Up @@ -117,6 +118,7 @@ pub type UncheckedExtrinsic =
pub type Migrations = (
// permanent
pallet_xcm::migration::MigrateToLatestXcmVersion<Runtime>,
migrations::FixMigration,
);

/// Executive: handles dispatch to the various modules.
Expand All @@ -140,7 +142,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: create_runtime_str!("coretime-polkadot"),
impl_name: create_runtime_str!("coretime-polkadot"),
authoring_version: 1,
spec_version: 1_003_000,
spec_version: 1_003_003,
impl_version: 0,
apis: RUNTIME_API_VERSIONS,
transaction_version: 0,
Expand Down
Loading
Loading