Update foreign asset ids from v3 to v4 #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
approved these changes
Oct 8, 2024
bkontur
approved these changes
Oct 15, 2024
acatangiu
approved these changes
Oct 17, 2024
integration-tests/emulated/tests/assets/asset-hub-kusama/src/tests/swap.rs
Outdated
Show resolved
Hide resolved
integration-tests/emulated/tests/assets/asset-hub-kusama/src/tests/swap.rs
Outdated
Show resolved
Hide resolved
integration-tests/emulated/tests/assets/asset-hub-kusama/src/tests/swap.rs
Outdated
Show resolved
Hide resolved
pandres95
approved these changes
Oct 18, 2024
This was referenced Oct 20, 2024
We're planning on removing v2 as soon as v5 comes out. |
kianenigma
approved these changes
Oct 24, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit 21f767d
into
polkadot-fellows:main
48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #209
Foreign assets in Asset Hub Kusama and Asset Hub Polkadot use v3 locations as ids. The newest version is v4 so this PR updates them.
No storage migration is needed since v3's and v4's encoding is the same.
Had to copy some test functions that took v3 locations into the repo until we update it to stable2409, when they actually switch to taking v4 locations.