Update Rust version #473
Update Rust version #473
Conversation
|
@ggwpez, can you tell me if it's acceptable for "Check Migrations" to fail here? |
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| pub use pallet_custom_origins::*; | |||
|
|
|||
| #[allow(unreachable_patterns)] | |||
There was a problem hiding this comment.
What warning is this suppressing? I removed them locally and just running clippy seems fine.
Otherwise please open a bug report in the SDK, the FRAME macros should not produce warnings.
There was a problem hiding this comment.
Let's try to remove it and look at CI
There was a problem hiding this comment.
Otherwise please open a bug report in the SDK, the FRAME macros should not produce warnings.
Wasn't there a fix for something similar in the SDK pr that upgraded the rust version?
There was a problem hiding this comment.
paritytech/polkadot-sdk#5697 okay maybe it wasn't fixed. I checked the pr again.
|
Review required! Latest push from author must always be reviewed |
| @@ -19,6 +19,7 @@ | |||
| use super::ranks; | |||
| pub use pallet_origins::*; | |||
|
|
|||
| #[allow(unreachable_patterns)] | |||
There was a problem hiding this comment.
Would be nice to have an issue to remove this when we have upgraded to the polkadot-sdk version that fixes this.
This reverts commit 7530862.
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit 123f8f4
into
polkadot-fellows:main
Fixes #470
#[allow(unreachable_patterns)](controversial)timeupdated to 0.3.36